Abw 1805 pool unit view UI #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add real image for the resource
Align the borders around tokens and nfts
…-pool-unit-view-ui # Conflicts: # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit.swift
This reverts commit b06385b.
Localize
# Conflicts: # Sources/Features/AssetsFeature/AssetsView+Reducer.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit+View.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/PoolUnitsList.swift
# Conflicts: # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift # Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit+View.swift
GhenadieVP
approved these changes
Aug 10, 2023
Sources/Features/AssetsFeature/Components/DetailsContainerWithHeaderView.swift
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/DetailsContainerWithHeaderView.swift
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/DetailsContainerWithHeaderView.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/DetailsContainerWithHeaderView.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1805
Description
This PR brings the UI and wiring to the Pool Unit details.
Testing notes
In the process, I extracted
DetailsContainerWithHeaderViewthat is reused by both Tokens and Pool Units tabs. Token details should be checked for regressions.Screenshots