[ABW-1304] Behaviours and tags #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhenadieVP
approved these changes
Aug 16, 2023
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
GhenadieVP
reviewed
Aug 16, 2023
...eature/Components/NonFungibleAssetList/Components/Details/NonFungibleTokenDetails+View.swift
Outdated
Show resolved
Hide resolved
|
Separate question - shouldn't the behaviours and tags be also displayed in Poll Unit related details? |
CyonAlexRDX
approved these changes
Aug 16, 2023
App/BabylonWallet.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
Very possibly. That view didn't exist when I started this, but I will check and add it there. |
kugel3
force-pushed
the
ABW-1304-Behaviours-and-tags
branch
from
269846e to
b81019f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1304
Proposal
Description
Adds logic and UI for behaviors and tags, for fungible and non-fungible resources. Only shown in the respective details screens.
Notes
When we can't parse the RoleKey.name string to something recognizable (like "minter"), we ignore it, which is probably the only reasonable option. There is also the case where the
explicit_rulevalue can't be parsed to one of "DenyAll", "AllowAll" and "Protected". That case is now treated the same as the Protected case (and the non-explicit, owner case), meaning that we assume that someone, but not anyone, is able to either perform or update the role in question.What details are we showing:
NFTS:
description
resourceAddress
resourceName
(currentSupply should be here, when we have it)
behaviors
tags
Fungibles:
description
resourceAddress
currentSupply
behaviors
tags
LSUs and Pool Units:
description
resourceAddress
validatorAddress
resourceName (is this just the normal resource name?)
currentSupply
behaviors
tags
Screenshot