ABW-1788 improve nft card #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciek-rdx
added
the
DO NOT MERGE
|
Do not merge until we resolve these things |
Resolved, needs more work. See the comment in the ticket. |
# Conflicts: # Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift # Sources/Core/SharedModels/Assets/AccountPortfolio.swift # Sources/Features/AssetsFeature/Components/HelperViews/NFTHelperViews.swift
maciek-rdx
removed
the
DO NOT MERGE
Implemented, ready to go. |
GhenadieVP
approved these changes
Aug 18, 2023
Sources/Clients/AccountPortfoliosClient/AccountPortfoliosClient+Live.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Aug 18, 2023
Sources/Features/AssetsFeature/Components/HelperViews/NFTHelperViews.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Aug 18, 2023
Sources/Features/AssetsFeature/Components/HelperViews/NFTHelperViews.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Aug 18, 2023
.../AssetsFeature/Components/NonFungibleAssetList/Components/Row/NonFungibleAssetRow+View.swift
Outdated
Show resolved
Hide resolved
kugel3
reviewed
Aug 18, 2023
Sources/Features/AssetsFeature/Components/HelperViews/NFTHelperViews.swift
Outdated
Show resolved
Hide resolved
kugel3
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1788
Description
This PR brings in the updated NFT card
Notes
Please ignore the missing NFT images - it's a separate card.
Screenshot