Third party asset deposit rule - local #679
Conversation
…ird-party-asset-deposit-rule
…ird-party-asset-deposit-rule
…hird-party-asset-deposit-rule
GhenadieVP
changed the title
...s/Features/AccountPreferencesFeature/Children/ThirdPartyDeposits/ResourcesList+Reducer.swift
Outdated
Show resolved
Hide resolved
| if !viewStore.resources.isEmpty { | ||
| listView(viewStore) | ||
| } | ||
| Spacer() |
There was a problem hiding this comment.
Spacer needed? should use minLength: 0 if so?
Sources/Features/AccountPreferencesFeature/Children/ThirdPartyDeposits/ResourcesList+View.swift
Outdated
Show resolved
Hide resolved
| Group { | ||
| if case let .allowDenyAssets(exceptionRule) = viewStore.mode { | ||
| Picker( | ||
| "", |
There was a problem hiding this comment.
What are the implications of using "" here? I think for accessibility sake we wanna set it?
There was a problem hiding this comment.
It describes the purpose, meant to add it, but forgot. Thx for reminder.
| } | ||
| .padding(.leading, .medium3) | ||
|
|
||
| Spacer() |
| .padding(.large3) | ||
| .background(.app.background) | ||
|
|
||
| Spacer() |
There was a problem hiding this comment.
trailing Spacer needed?
There was a problem hiding this comment.
yes, to push the content of the VStack on top.
| .keyboardType(.asciiCapable) | ||
| .autocorrectionDisabled() | ||
|
|
||
| WithControlRequirements( |
There was a problem hiding this comment.
Should WithControlReq... be in a footer?
There was a problem hiding this comment.
For this scenario no, the button is shown near the text field as it is the only UI element in the screen.
|
|
||
| case .allowDenyAssets: | ||
| state.destinations = .allowDenyAssets(.init( | ||
| mode: .allowDenyAssets(.allow), |
There was a problem hiding this comment.
.allowDenyAsserts(.allow) is a little hard to understand, does this mean we start in segment allow, a label would help!
There was a problem hiding this comment.
yes, will add a label
GhenadieVP
deleted the
fix/ABW-1766-i-os-third-party-asset-deposit-rule
branch
Brings in Third Party deposits:
Video -> https://drive.google.com/file/d/1530qDqWas1-PUNsfk82zOmbdu70dQHhx/view?usp=drive_link