Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third party deposits ledger #692

Merged
merged 83 commits into from
Sep 15, 2023
Merged

Third party deposits ledger #692

merged 83 commits into from
Sep 15, 2023

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Aug 29, 2023 •
edited
Loading

Third party deposits config on Ledger.

What was done:

  • Build the transaction manifest for changing the ThirdPartyDeposits.
  • Added the ability in DappInteractorClient to wait for the interaction finalization.
RPReplay_Final1694411870.MP4

@GhenadieVP
add children folder
0ce633e
@GhenadieVP
generic section
f1e21e1
@GhenadieVP
wip
aaff5ac
@GhenadieVP
wip
d362d04
@GhenadieVP
wip
66f96db
@GhenadieVP
wip
e319a33
@GhenadieVP
wip
4abc53e
@GhenadieVP
wip
24fd0a7
@GhenadieVP
add asset ui adjustements
37d74ff
@GhenadieVP
add nft id
ecd990c
@GhenadieVP
reusable resources list
ff6aede
@GhenadieVP
wip
d9c8459
@GhenadieVP
profile update
e37f009
@GhenadieVP
update tests
328882b
@GhenadieVP
Merge branch 'third_party_deposits_profile' into fix/ABW-1766-i-os-th…
5179494 
…ird-party-asset-deposit-rule
@GhenadieVP
link with profile
19bf83e
@GhenadieVP
Prepare for new client
5e48b17
@GhenadieVP
onLedgerclient
6d1bb7d
@GhenadieVP
impr
fab08df
@GhenadieVP
Merge branch 'third_party_deposits_profile' into fix/ABW-1766-i-os-th…
e30afc0 
…ird-party-asset-deposit-rule
@GhenadieVP
client
eb29f7c
@GhenadieVP
wip
dd6b5bd
@GhenadieVP
improve
86308e5
@GhenadieVP
asset exception can be only resource address
230acd2
@GhenadieVP
format
c954ad3
@GhenadieVP
Merge branch 'profile-thirdPartyDeposit-fix' into fix/ABW-1766-i-os-t…
c26d9db 
…hird-party-asset-deposit-rule
@GhenadieVP
wip
2ff78c9
@GhenadieVP
impr
36f9db1
@GhenadieVP
wip
77ff217
@GhenadieVP
wip
3fda42e
@CyonAlexRDX CyonAlexRDX added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Aug 31, 2023
CyonAlexRDX added a commit that referenced this pull request Aug 31, 2023
@CyonAlexRDX
Temporarily hiding Third Party Deposit settings in UI since it does n…
1fb7f25 
…ot do anything yet and the PR #692 which has logic contains the TCA Send bug.
@CyonAlexRDX CyonAlexRDX mentioned this pull request Aug 31, 2023
Merged
@GhenadieVP GhenadieVP force-pushed the third_party_deposits_ledger branch from c68ea50 to 12ba9e6 Compare September 11, 2023 05:23
@GhenadieVP GhenadieVP marked this pull request as ready for review September 11, 2023 06:00
@GhenadieVP GhenadieVP marked this pull request as draft September 11, 2023 08:06
@GhenadieVP GhenadieVP marked this pull request as ready for review September 13, 2023 09:00
@GhenadieVP GhenadieVP removed the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Sep 13, 2023
CyonAlexRDX
CyonAlexRDX approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backgrounded app for a minute and it worked perfect to resume, good job!

@GhenadieVP GhenadieVP merged commit 38d35ca into main Sep 15, 2023
@GhenadieVP GhenadieVP deleted the third_party_deposits_ledger branch September 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciek-rdx maciek-rdx maciek-rdx approved these changes

@kugel3 kugel3 kugel3 approved these changes

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GhenadieVP @maciek-rdx @CyonAlexRDX @kugel3