[ABW-2168] Bug fix - Show totalExecutionCost under "NETWORK EXECUTION" (instead of executionCost)
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
changed the title
totalExecutionCost under "NETWORK EXECUTION" (instead of executionCost)
raf-rdx
approved these changes
Sep 1, 2023
kugel3
reviewed
Sep 1, 2023
| name: L10n.TransactionReview.CustomizeNetworkFeeSheet.royalties, | ||
| amount: feeSummary.royaltyCost, | ||
| isUserConfigurable: false | ||
| ), | ||
| ]) | ||
|
|
||
| if paidByDapps > .zero { |
There was a problem hiding this comment.
Personally, I would prefer base to be mutable and called result, and you append to it. Failing that, at least put return base in an else. This is just stylistic, obviously.
There was a problem hiding this comment.
not my code, but agreed, will fix
kugel3
reviewed
Sep 1, 2023
| state.networkFee = .init(reviewedTransaction: reviewedTransaction) | ||
| } | ||
| state.networkFee = .init(reviewedTransaction: reviewedTransaction) | ||
| // printFeePayerInfo() |
There was a problem hiding this comment.
will be fixed now, when merging main into this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-2168
Description
Solves UI bug on iOS were we accidentally displayed
executionCostinstead oftotalExecutionCostwhich is correct to show.How to test
Use Gumball Club dapp, send a swap tx, check the Advanced Fee view and assert that if you sum up all the parts, the sum eq the TRANSACTION FEE displayed in the bottom.
Screenshot
Video
RPReplay_Final1693564218.MP4
PR submission checklist