Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: don't fail on snyk vulnerabilities which doesn't have fix #781

Merged
merged 13 commits into from
Oct 20, 2023
Merged

ci: don't fail on snyk vulnerabilities which doesn't have fix #781

merged 13 commits into from
Oct 20, 2023

Conversation

marek-karwacki-rdx
Copy link
Contributor

@marek-karwacki-rdx marek-karwacki-rdx commented Oct 20, 2023 •
edited
Loading

Pass snyk image scan job if there is vulnerability found but there is no fixed version yet (this is how --fail-on=all works 🙃 )

@marek-karwacki-rdx marek-karwacki-rdx changed the title ci: ignore snyk vulnerability ci: don't fail on snyk vulnerabilities which doesn't have fix Oct 20, 2023
@marek-karwacki-rdx marek-karwacki-rdx marked this pull request as ready for review October 20, 2023 11:41
@marek-karwacki-rdx marek-karwacki-rdx requested a review from a team as a code owner October 20, 2023 11:41
@sonarqubecloud
Copy link

[radixdlt_console] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[radixdlt_dashboard] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marek-karwacki-rdx marek-karwacki-rdx merged commit f951772 into main Oct 20, 2023
29 checks passed
@marek-karwacki-rdx marek-karwacki-rdx deleted the ignore-snyk-vuln branch October 20, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shambupujar shambupujar shambupujar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marek-karwacki-rdx @shambupujar