Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fxhash - TEST ONLY #1960

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

use fxhash - TEST ONLY #1960

wants to merge 1 commit into from

Conversation

lrubasze
Copy link
Contributor

Summary

INSTRUCTIONS:
Add summary - one or two sentences explaining the purpose of this PR.

Details

INSTRUCTIONS:
Provide further details about the changes, or how they fit into the roadmap.
You can delete this section if it's not useful.

Testing

INSTRUCTIONS:
Further details about the tests you've added or manually performed.
You can delete this section if it's not useful.

Update Recommendations

INSTRUCTIONS:
This section is to provide recommendations to consumers of this repo about how they
should handle breaking changes, or integrate new features. The two key stakeholder
groups are dApp Developers and Internal Integrators, and there are separate sections
for each.

In order to allow us to compile aggregated update instructions across PRs, please tag the PR
with 0+ of the relevant labels:
* scrypto-lib - Any change to the scrypto library
* sbor - Any breaking change to SBOR encoding/decoding
* manifest - Any change to manifest display, compilation/decompilation
* transaction - Any change which affects the compiled manifest, or transaction semantics
* substate - Any change to substates, the state model, or what's stored in the DB
* native-blueprint-interface - Any change to the interface of native blueprints
* files-moved - Any change to where engine types have moved, which will require
  internal integrators to update their imports

If you have a breaking change which doesn't fix into a category above, then tag it with
the closest label, and discuss in slack/discord.

If your PR contains no breaking changes or new features or hasn't been tagged, this whole
section can be deleted.

For dApp Developers

INSTRUCTIONS:
Migration recommendations for a dApp developer to update their dApp/integrations
due to to the change/s in this PR.

These will be aggregated by the Developer Ecosystem team and included in the next Scrypto migration guide
(eg https://docs-babylon.radixdlt.com/main/scrypto/release_notes/migrating_from_0.7_to_0.8.html )

For Internal Integrators

INSTRUCTIONS:
Instructions to any internal integrations (eg Node, Toolkit, Gateway, Ledger App) for how the changes may affect
them and recommendations for how they should update to support this change.

Copy link

Phylum Report Link

Copy link

Docker tags
docker.io/radixdlt/private-scrypto-builder:36b35739ed

Copy link

Benchmark for 36b3573

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 44.9±0.09ms 44.4±0.26ms -1.11%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.6±0.11ms 19.1±0.05ms -2.55%
costing::decode_encoded_i8_array_to_manifest_value 41.5±0.06ms 41.7±0.11ms +0.48%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.2±0.11ms 70.8±0.14ms -1.94%
costing::decode_encoded_tuple_array_to_manifest_value 99.0±0.33ms 100.9±0.16ms +1.92%
costing::decode_encoded_u8_array_to_manifest_raw_value 32.4±0.15µs 26.0±0.15µs -19.75%
costing::decode_encoded_u8_array_to_manifest_value 41.4±0.10ms 41.7±0.10ms +0.72%
costing::decode_rpd_to_manifest_raw_value 15.2±0.04µs 14.1±0.03µs -7.24%
costing::decode_rpd_to_manifest_value 10.9±0.07µs 10.9±0.05µs 0.00%
costing::deserialize_wasm 1299.4±4.56µs 1274.8±3.43µs -1.89%
costing::execute_transaction_creating_big_vec_substates 695.8±8.59ms 697.1±7.43ms +0.19%
costing::execute_transaction_reading_big_vec_substates 587.0±1.62ms 583.1±2.09ms -0.66%
costing::instantiate_flash_loan 997.3±1080.15µs 975.3±1404.49µs -2.21%
costing::instantiate_radiswap 892.0±334.34µs 864.8±275.68µs -3.05%
costing::spin_loop 21.7±0.06ms 21.1±0.04ms -2.76%
costing::spin_loop_v2 3.0±0.00s 3.1±0.00s +3.33%
costing::spin_loop_v3 734.1±6.11ms 728.5±8.32ms -0.76%
costing::validate_sbor_payload 32.5±0.12µs 30.9±0.09µs -4.92%
costing::validate_sbor_payload_bytes 263.7±0.73ns 245.7±0.63ns -6.83%
costing::validate_secp256k1 76.7±0.13µs 76.6±0.20µs -0.13%
costing::validate_wasm 34.4±0.04ms 33.8±0.04ms -1.74%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.9±0.01ns 9.9±0.01ns 0.00%
decimal::add/wasmi 221.1±0.89ns 224.9±0.52ns +1.72%
decimal::add/wasmi-call-native 2.1±0.01µs 2.2±0.00µs +4.76%
decimal::div/0 186.7±0.10ns 186.2±0.08ns -0.27%
decimal::from_string/0 151.8±0.20ns 153.4±0.14ns +1.05%
decimal::mul/0 151.1±0.12ns 149.6±0.31ns -0.99%
decimal::mul/rust-native 147.2±0.02ns 147.6±0.07ns +0.27%
decimal::mul/wasmi 11.9±0.05µs 11.8±0.04µs -0.84%
decimal::mul/wasmi-call-native 2.3±0.01µs 2.3±0.00µs 0.00%
decimal::pow/0 693.6±0.68ns 700.6±0.86ns +1.01%
decimal::pow/rust-native 680.9±0.68ns 681.2±0.91ns +0.04%
decimal::pow/wasmi 59.3±0.36µs 57.8±0.19µs -2.53%
decimal::pow/wasmi-call-native 3.4±0.00µs 3.7±0.00µs +8.82%
decimal::root/0 7.9±0.00µs 8.0±0.01µs +1.27%
decimal::sub/0 8.6±0.45ns 8.3±0.28ns -3.49%
decimal::to_string/0 448.2±0.44ns 445.1±0.19ns -0.69%
large_transaction_processing::prepare 2.6±0.00ms 2.6±0.00ms 0.00%
large_transaction_processing::prepare_and_decompile 7.0±0.03ms 6.9±0.02ms -1.43%
large_transaction_processing::prepare_and_decompile_and_recompile 28.6±1.39ms 32.6±0.31ms +13.99%
precise_decimal::add/0 9.1±0.02ns 9.1±0.01ns 0.00%
precise_decimal::add/rust-native 10.7±0.03ns 10.7±0.03ns 0.00%
precise_decimal::add/wasmi 274.7±2.13ns 280.4±0.94ns +2.07%
precise_decimal::add/wasmi-call-native 2.8±0.01µs 2.8±0.00µs 0.00%
precise_decimal::div/0 336.1±0.25ns 349.5±4.12ns +3.99%
precise_decimal::from_string/0 207.2±0.38ns 207.6±0.56ns +0.19%
precise_decimal::mul/0 365.4±0.49ns 365.5±0.39ns +0.03%
precise_decimal::mul/rust-native 319.2±0.27ns 318.7±0.44ns -0.16%
precise_decimal::mul/wasmi 34.0±0.16µs 34.8±0.48µs +2.35%
precise_decimal::mul/wasmi-call-native 3.2±0.01µs 3.2±0.00µs 0.00%
precise_decimal::pow/0 1926.9±1.38ns 2.0±0.01µs +3.79%
precise_decimal::pow/rust-native 1521.0±1.78ns 1527.1±3.01ns +0.40%
precise_decimal::pow/wasmi 170.4±2.21µs 163.7±0.25µs -3.93%
precise_decimal::pow/wasmi-call-native 5.7±0.02µs 5.7±0.01µs 0.00%
precise_decimal::root/0 58.1±0.03µs 58.3±0.02µs +0.34%
precise_decimal::sub/0 9.2±0.03ns 9.2±0.05ns 0.00%
precise_decimal::to_string/0 698.0±0.77ns 699.2±1.38ns +0.17%
schema::validate_payload 363.0±0.68µs 358.4±0.76µs -1.27%
transaction::radiswap 5.0±0.02ms 4.6±0.03ms -8.00%
transaction::transfer 1911.1±10.65µs 1735.3±12.95µs -9.20%
transaction_validation::validate_manifest 43.2±0.18µs 43.1±0.07µs -0.23%
transaction_validation::verify_bls_2KB 1003.6±12.94µs 1044.7±30.34µs +4.10%
transaction_validation::verify_bls_32B 1003.0±10.03µs 1003.5±8.97µs +0.05%
transaction_validation::verify_ecdsa 74.7±0.05µs 75.8±0.08µs +1.47%
transaction_validation::verify_ed25519 42.0±0.07µs 42.2±0.08µs +0.48%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant