Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Include non root subintent hashes on UserTransactionHashes #1994

Merged

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Oct 31, 2024

Summary

Minor PR to fit with node integration.

@dhedey dhedey force-pushed the tweak/add-non-root-subintent-hashes-to-user-transaction-hashes branch from 08621ce to 6346e08 Compare October 31, 2024 14:48
Copy link

github-actions bot commented Oct 31, 2024

Docker tags
docker.io/radixdlt/private-scrypto-builder:edc3f334f8

Copy link

github-actions bot commented Oct 31, 2024

Benchmark for edc3f33

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 45.2±0.30ms 45.0±0.17ms -0.44%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.3±0.04ms 19.3±0.05ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 42.5±0.08ms 42.5±0.11ms 0.00%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.3±0.17ms 72.4±0.24ms +0.14%
costing::decode_encoded_tuple_array_to_manifest_value 108.6±0.28ms 98.1±0.22ms -9.67%
costing::decode_encoded_u8_array_to_manifest_raw_value 26.1±0.08µs 32.9±0.12µs +26.05%
costing::decode_encoded_u8_array_to_manifest_value 42.6±0.13ms 42.5±0.10ms -0.23%
costing::decode_rpd_to_manifest_raw_value 14.7±0.06µs 14.6±0.07µs -0.68%
costing::decode_rpd_to_manifest_value 11.1±0.05µs 10.9±0.07µs -1.80%
costing::deserialize_wasm 1234.7±7.61µs 1231.5±7.28µs -0.26%
costing::execute_transaction_creating_big_vec_substates 697.2±7.77ms 696.6±9.46ms -0.09%
costing::execute_transaction_reading_big_vec_substates 593.6±1.27ms 589.1±0.65ms -0.76%
costing::instantiate_flash_loan 1036.7±1162.38µs 979.7±1047.44µs -5.50%
costing::instantiate_radiswap 915.9±690.83µs 1037.2±1253.64µs +13.24%
costing::scrypto_malloc 493.0±0.80ms 506.4±0.94ms +2.72%
costing::scrypto_sbor_decode 529.9±1.56ms 528.7±1.70ms -0.23%
costing::scrypto_sha256 441.9±1.02ms 441.6±1.04ms -0.07%
costing::spin_loop_v1 434.2±0.57ms 440.7±1.15ms +1.50%
costing::spin_loop_v2 543.6±1.47ms 546.4±1.58ms +0.52%
costing::validate_sbor_payload 30.0±0.13µs 30.1±0.09µs +0.33%
costing::validate_sbor_payload_bytes 247.1±1.49ns 244.8±1.01ns -0.93%
costing::validate_secp256k1 76.8±0.26µs 76.8±0.22µs 0.00%
costing::validate_wasm 33.9±0.09ms 34.1±0.10ms +0.59%
decimal::add/0 8.4±0.01ns 8.4±0.02ns 0.00%
decimal::add/rust-native 9.8±0.01ns 9.8±0.02ns 0.00%
decimal::add/wasmi 218.2±1.38ns 220.4±0.46ns +1.01%
decimal::add/wasmi-call-native 2.1±0.00µs 2.1±0.01µs 0.00%
decimal::div/0 169.6±0.31ns 169.1±0.41ns -0.29%
decimal::from_string/0 157.4±0.49ns 156.5±0.58ns -0.57%
decimal::mul/0 128.6±0.31ns 129.3±0.24ns +0.54%
decimal::mul/rust-native 126.5±0.30ns 128.5±0.20ns +1.58%
decimal::mul/wasmi 11.2±0.17µs 11.7±0.09µs +4.46%
decimal::mul/wasmi-call-native 2.2±0.00µs 2.2±0.01µs 0.00%
decimal::pow/0 598.3±1.29ns 595.3±0.63ns -0.50%
decimal::pow/rust-native 591.3±1.11ns 590.4±0.62ns -0.15%
decimal::pow/wasmi 60.5±0.56µs 58.3±0.22µs -3.64%
decimal::pow/wasmi-call-native 3.2±0.01µs 3.2±0.01µs 0.00%
decimal::root/0 8.0±0.02µs 8.3±0.02µs +3.75%
decimal::sub/0 8.3±0.01ns 8.3±0.01ns 0.00%
decimal::to_string/0 441.7±0.74ns 440.7±2.88ns -0.23%
large_transaction_processing::prepare 2.6±0.01ms 2.6±0.01ms 0.00%
large_transaction_processing::prepare_and_decompile 6.2±0.04ms 6.2±0.03ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 32.5±0.35ms 31.9±0.12ms -1.85%
metadata_validation::validate_urls 4.8±0.02µs 5.0±0.06µs +4.17%
precise_decimal::add/0 9.0±0.02ns 9.0±0.02ns 0.00%
precise_decimal::add/rust-native 10.7±0.02ns 10.7±0.03ns 0.00%
precise_decimal::add/wasmi 277.2±0.72ns 276.7±0.82ns -0.18%
precise_decimal::add/wasmi-call-native 2.8±0.01µs 2.8±0.01µs 0.00%
precise_decimal::div/0 321.5±2.32ns 314.0±1.13ns -2.33%
precise_decimal::from_string/0 201.9±0.34ns 201.5±0.48ns -0.20%
precise_decimal::mul/0 373.6±2.05ns 367.2±2.16ns -1.71%
precise_decimal::mul/rust-native 284.9±0.89ns 285.9±0.30ns +0.35%
precise_decimal::mul/wasmi 33.7±0.29µs 34.0±0.24µs +0.89%
precise_decimal::mul/wasmi-call-native 3.1±0.01µs 3.1±0.00µs 0.00%
precise_decimal::pow/0 1796.9±5.82ns 1791.0±10.77ns -0.33%
precise_decimal::pow/rust-native 1374.6±1.71ns 1390.6±4.64ns +1.16%
precise_decimal::pow/wasmi 165.9±2.05µs 165.4±0.69µs -0.30%
precise_decimal::pow/wasmi-call-native 5.4±0.01µs 5.4±0.01µs 0.00%
precise_decimal::root/0 58.4±0.04µs 58.4±0.09µs 0.00%
precise_decimal::sub/0 9.3±0.16ns 9.2±0.04ns -1.08%
precise_decimal::to_string/0 694.0±0.86ns 693.1±0.78ns -0.13%
schema::validate_payload 404.4±1.24µs 380.2±0.93µs -5.98%
transaction::radiswap 4.8±0.02ms 4.8±0.03ms 0.00%
transaction::transfer 1817.4±5.94µs 1795.5±6.00µs -1.21%
transaction_validation::validate_manifest 43.4±0.50µs 43.2±0.16µs -0.46%
transaction_validation::verify_bls_2KB 1066.6±44.68µs 1006.9±11.47µs -5.60%
transaction_validation::verify_bls_32B 1064.2±14.51µs 1010.8±20.19µs -5.02%
transaction_validation::verify_ecdsa 74.8±0.20µs 74.8±0.36µs 0.00%
transaction_validation::verify_ed25519 47.8±0.13µs 42.7±0.18µs -10.67%

@dhedey dhedey merged commit 86080d6 into develop Oct 31, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants