Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check prerequisites for building a Security Shield #292

Conversation

matiasbzurovski
Copy link
Contributor

Changelog

  • Adds FactorSourceCategory & SecurityShieldPrerequisitesStatus to allow checking if a Security Shield can be built on the current Profile.

Note

target branch is ABW-3848-security-problems to avoid conflicts.


/// An enum representing the **category** of a `FactorSource`/`FactorSourceKind`.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum FactorSourceCategory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FactorSourceKindCategory imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this but went with FactorSourceCategory because kind and category are synonyms, so it sounded a bit weird. Also, given a FactorSource can be categorized as well (in fact, it is how we use it) I think this makes more sense.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (ac/security_structures_matrices_roles_with_rules@3ee614f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##             ac/security_structures_matrices_roles_with_rules    #292   +/-   ##
==================================================================================
  Coverage                                                    ?   93.4%           
==================================================================================
  Files                                                       ?    1087           
  Lines                                                       ?   22531           
  Branches                                                    ?      77           
==================================================================================
  Hits                                                        ?   21053           
  Misses                                                      ?    1464           
  Partials                                                    ?      14           
Flag Coverage Δ
kotlin 97.9% <ø> (?)
rust 92.3% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...profile/logic/account/query_security_structures.rs 92.0% <100.0%> (ø)
...ity_structures/matrices/builder/matrix_template.rs 98.8% <100.0%> (ø)
...structures/matrices/matrix_of_factor_source_ids.rs 89.1% <100.0%> (ø)
...gon/src/profile/v100/factors/factor_source_kind.rs 100.0% <100.0%> (ø)
...argon/src/profile/v100/factors/is_factor_source.rs 50.0% <100.0%> (ø)
.../system/sargon_os/sargon_os_security_structures.rs 86.0% <100.0%> (ø)

Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@CyonAlexRDX CyonAlexRDX merged commit 9f66118 into ac/security_structures_matrices_roles_with_rules Dec 6, 2024
11 of 13 checks passed
@CyonAlexRDX CyonAlexRDX deleted the mb/factor_source_category branch December 6, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants