-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check prerequisites for building a Security Shield #292
Check prerequisites for building a Security Shield #292
Conversation
|
||
/// An enum representing the **category** of a `FactorSource`/`FactorSourceKind`. | ||
#[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
pub enum FactorSourceCategory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FactorSourceKindCategory imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this but went with FactorSourceCategory
because kind
and category
are synonyms, so it sounded a bit weird. Also, given a FactorSource
can be categorized as well (in fact, it is how we use it) I think this makes more sense.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ac/security_structures_matrices_roles_with_rules #292 +/- ##
==================================================================================
Coverage ? 93.4%
==================================================================================
Files ? 1087
Lines ? 22531
Branches ? 77
==================================================================================
Hits ? 21053
Misses ? 1464
Partials ? 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
crates/sargon/src/system/sargon_os/sargon_os_security_structures.rs
Outdated
Show resolved
Hide resolved
crates/sargon/src/profile/v100/factors/factor_source_category.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
9f66118
into
ac/security_structures_matrices_roles_with_rules
Changelog
FactorSourceCategory
&SecurityShieldPrerequisitesStatus
to allow checking if a Security Shield can be built on the current Profile.Note
target branch is
ABW-3848-security-problems
to avoid conflicts.