Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ManifestSummary classification #304

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Dec 16, 2024

  • Updates RET to bring in GeneralSubintent manifest classification.
  • Exposed ManifestSummary classification so it can be used in hosts to determine the classification of the open Pre-Auth.
  • The main intent is to display the proper UI only for GeneralSubintent, and raw manifest for other classifications.

Context - https://rdxworks.slack.com/archives/C031A0V1A1W/p1734031336038489

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.2%. Comparing base (51c15f1) to head (0bfcdfa).

Files with missing lines Patch % Lines
...ow_level/execution_summary/reserved_instruction.rs 50.0% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #304     +/-   ##
=======================================
- Coverage   93.2%   93.2%   -0.1%     
=======================================
  Files       1104    1104             
  Lines      23283   23303     +20     
  Branches      79      79             
=======================================
+ Hits       21717   21735     +18     
- Misses      1551    1553      +2     
  Partials      15      15             
Flag Coverage Δ
kotlin 97.1% <ø> (ø)
rust 92.7% <90.0%> (-0.1%) ⬇️
swift 94.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/sargon/src/core/has_sample_values.rs 65.3% <100.0%> (+6.2%) ⬆️
..._os/transactions/sargon_os_transaction_analysis.rs 83.1% <ø> (ø)
...kit/low_level/manifest_summary/manifest_summary.rs 98.7% <100.0%> (+0.1%) ⬆️
...el/v1/transaction_manifest/transaction_manifest.rs 98.6% <ø> (ø)
...l/v2/transaction_manifest_v2/subintent_manifest.rs 97.8% <ø> (ø)
...transaction_manifest_v2/transaction_manifest_v2.rs 93.3% <ø> (ø)
...ow_level/execution_summary/reserved_instruction.rs 85.7% <50.0%> (-14.3%) ⬇️

@GhenadieVP GhenadieVP merged commit 0c5278b into main Dec 16, 2024
13 checks passed
@GhenadieVP GhenadieVP deleted the subintent_classification branch December 16, 2024 11:39
/// A subintent manifest which satisfies the general rules allowed for in
/// general transactions and that includes a [`YieldToParent`] instruction.
///
/// [`YieldToParent`]: radix_transactions::manifest::YieldToParent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants