-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Split Sargon into many crates #318
Open
CyonAlexRDX
wants to merge
6
commits into
main
Choose a base branch
from
ac/split
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
force-pushed
the
ac/split
branch
from
December 23, 2024 09:16
bb76f34
to
197faea
Compare
Split out HD crate
Split out module `Factors` and others into separate crates Split out module `Addresses` & `KeysCollector` into new crates
CyonAlexRDX
changed the title
[WIP - EPIC] Split Sargon into many crates
[WIP] Split Sargon into many crates
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Mergable even if
check-version
andcode-coverage
checks failsince I've bumped versions to 1.2 and no longer tarpaulin ignore some files (can improve/fix later)
See tracking issue #317
I will use this branch / PR as an umbrella target for all smaller PRs as to not change main
New crates: