Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Split Sargon into many crates #318

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[WIP] Split Sargon into many crates #318

wants to merge 6 commits into from

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Dec 21, 2024

Note

Mergable even if check-version and code-coverage checks fail
since I've bumped versions to 1.2 and no longer tarpaulin ignore some files (can improve/fix later)

See tracking issue #317

I will use this branch / PR as an umbrella target for all smaller PRs as to not change main

New crates:

  • sargon-core-utils
  • sargon-core-error
  • sargon-core-assert-json
  • identified-vec-of
  • sargon-core
  • sargon-hierarchical-deterministic
  • sargon-factors
  • sargon-addresses
  • sargon-keys-collector

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 96.51163% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.1%. Comparing base (e18bd66) to head (81aef4b).

Files with missing lines Patch % Lines
.../test_keys_collector/test_derivation_interactor.rs 87.5% 3 Missing ⚠️
crates/sargon-core/src/has_sample_values.rs 83.3% 2 Missing ⚠️
...argon-factors/src/factor_source_id_from_address.rs 75.0% 2 Missing ⚠️
...s/identified-vec-of/src/identified_vec_of_serde.rs 0.0% 1 Missing ⚠️
...s/sargon-addresses/src/address/wrap_ret_address.rs 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #318     +/-   ##
=======================================
- Coverage   93.3%   93.1%   -0.2%     
=======================================
  Files       1111    1122     +11     
  Lines      24248   24781    +533     
  Branches      79      79             
=======================================
+ Hits       22637   23091    +454     
- Misses      1596    1675     +79     
  Partials      15      15             
Flag Coverage Δ
kotlin 97.1% <ø> (+<0.1%) ⬆️
rust 92.6% <96.3%> (-0.3%) ⬇️
swift 94.8% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...thods/Profile/CAP26EntityKind+Wrap+Functions.swift 100.0% <100.0%> (ø)
...ied/Crypto/Derivation/AccountPath+Swiftified.swift 100.0% <100.0%> (ø)
...ed/Crypto/Derivation/IdentityPath+Swiftified.swift 100.0% <100.0%> (ø)
...wiftified/Profile/CAP26EntityKind+Swiftified.swift 100.0% <100.0%> (ø)
...-vec-of/src/decl_identified_vec_of_with_samples.rs 100.0% <100.0%> (ø)
crates/identified-vec-of/src/identified_vec_of.rs 86.6% <ø> (ø)
...fied-vec-of/src/identified_vec_of_display_debug.rs 100.0% <ø> (ø)
...dentified-vec-of/src/identified_vec_of_iterator.rs 100.0% <ø> (ø)
.../identified-vec-of/src/identified_vec_of_modify.rs 86.6% <ø> (ø)
...s/identified-vec-of/src/identified_vec_of_query.rs 100.0% <ø> (ø)
... and 188 more

... and 54 files with indirect coverage changes

@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review December 30, 2024 08:55
@CyonAlexRDX CyonAlexRDX changed the title [WIP - EPIC] Split Sargon into many crates [WIP] Split Sargon into many crates Dec 30, 2024
@radixdlt radixdlt deleted a comment from Sajjon Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants