Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to v1 embedding #954

Merged

Conversation

gmackall
Copy link

@gmackall gmackall commented Jun 7, 2024

rafaelsetragni and others added 4 commits March 17, 2024 09:35
Community support migration from Github Issues to Discord Community.
@rafaelsetragni
Copy link
Owner

Hi @gmackall,

Thank you so much for your contribution!

In fact, we need to remove these old v1 references from example app. However, please note that pull requests should be made to the development branch, not the master branch.

Our branching strategy is as follows:

  • The master branch only contains versions that have been released to production.
  • All new features and changes should be merged into the development branch first.
  • Once the changes in the development branch are stable and tested, they are then grouped and merged into the release branch.
  • Finally, the release branch is merged into the master branch.

Could you please update your pull request to target the development branch?

Thank you!

@gmackall gmackall changed the base branch from master to development June 13, 2024 18:25
@gmackall
Copy link
Author

Changed the branch!

@rafaelsetragni rafaelsetragni merged commit 58f1e46 into rafaelsetragni:development Jun 13, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to deprecated v1 Android embedding
2 participants