-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use random temp directory for progress estimator (fix concurrent builds) #10
Conversation
@piter2k1 thanks for the PR. Supporting monorepos with concurrent builds is a good feature to add. There are two things that I am not sure about:
|
Also, is the monorepo you're using public? Or would you be able to create an example monorepo that uses |
@rafgraph You may be right. I will try some other implementations. I made this code as hot fix for our monorepo, so maybe I can fix this issue with simpler solution. Also, i will try to make repository with monorepo for testing it, but I need more time for that. |
I made some research in other libraries and I think I found a good solution. I used external library Now, I tested this on local monorepo (mac os) and on our company server by Jenkins build(docker centos), everythink was fine. And one more, when working with monorepo, we can run So, what is changed?
More about Percent progress estimator naturally also works fine 😄 |
@piter2k1 thanks for updating the PR. I really like your solution! I agree that I'm going to merge this and release a new patch version. It would be much appreciated if you could create an example monorepo using Rollpkg. I will link to it from the readme for others to use an example, as well as it will be helpful for smoke testing to prevent breaking monorepo support in the future. Thanks! |
Released |
I have been using
rollpkg
to build packages in monorepo bylerna
(https://github.com/lerna/lerna). I have one instance ofrollpkg
in root monorepo directory.lerna
builds 5-6 packages concurrently and sometimes one of builds ends withprogress-estimator
error. It uses the same cache folder for every build process, and sometimes it creates file conflict.I created this update to resolve this issue by using system tmp directory with random sub-directory for every new
rollpkg
build. I've been testing this for a month in my local monorepo and proposed solution works without any problems.