Spike - Dependabot - Upgrade react-scripts to 5.0

[jorgegonzalez]

Description:

Dependabot opened an upgrade to react-scripts@5.0.0. which includes breaking changes, and likely some unknown unknowns.

facebook/create-react-app#11756

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

• react-scripts is updated to latest major version
• file-type is updated to latest major version
• package.json is updated
• package-lock.json is updated
• Testing Checklist has been run and all tests pass
• README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

• Upgrade react-scripts to latest major version with npm
• Manually install required polyfills
• Run Testing Checklist and confirm all tests pass
• Generate follow-on tickets with identified improvements (e.g., compliance, ally refactor)

[jorgegonzalez]

#1575

[jorgegonzalez]

file-type should also be upgraded when this is implemented as react-scripts#5 will support ESM

ref:
sindresorhus/file-type#505
sindresorhus/file-type#502
sindresorhus/file-type#515
sindresorhus/file-type#521
sindresorhus/file-type#528

[valcollignon]

@ADPennington to sync with @jorgegonzalez on the priority of this ticket. per backlog refinement 2.8.22

[ADPennington]

per @jorgegonzalez, this is not a high priority and can be revisited in a later sprint. okay for the backlog @valcollignon cc: @abottoms-coder @lfrohlich

[andrew-jameson]

There are two dependabot vulnerability reports resulting from being unable to update react-scripts:

1. immer (Critical) -- Needs 9.0.6, we use 8.0.1
2. glob-parent (High) -- Needs 5.1.2, we use 3.1.0
3. node-forge (High) -- Needs 1.3, we use 0.10.0

[ADPennington]

3/16/22:

• decided during dev sync to revisit this ticket after nextgen xms epic (NextGen XMS Authentication Integration #1153) completed.
• dependabot security alerts (highs and criticals) will be discussed weekly at dev syncs.

[riatzukiza]

In #1813 dependabot notified us that redux 4.2.0 is depreciating the createStore interface we use, in favor of a new library react-toolkit
https://redux.js.org/introduction/why-rtk-is-redux-today. Since this is all it did, we closed it with out merging.

This change requires a full refactor of our redux code, it would be more readable and easier to maintain, and the changes aren't complicated, there would just be a lot of it. This is largely a quality of life update, and can probably be done around the same time as our update to react-scripts.

[lhuxraft]

Update to a tech memo ticket (spike) for next sprint

[lhuxraft]

11/20: Working on upgrading dependencies

[lhuxraft]

11/22: Making progress - updated most packages. Updated USWDS breaking changes. Working on getting tests to pass, more complex than expected. Will be doing a tech memo to recap work

[lhuxraft]

12/2: Having issue with file type library, experimenting with other libraries. Existing issues with tests

[lhuxraft]

Follow-on tickets may want to be taken in during following sprint (after Dec 17)

[lhuxraft]

12/4: Tests fixed and requested reviews

[lhuxraft]

12/9: Reviewing comments from Miles