Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecation warnings in unit tests #3329

Open
8 tasks
jtimpe opened this issue Dec 3, 2024 · 0 comments
Open
8 tasks

Resolve deprecation warnings in unit tests #3329

jtimpe opened this issue Dec 3, 2024 · 0 comments
Labels
dev Refined Ticket has been refined at the backlog refinement

Comments

@jtimpe
Copy link

jtimpe commented Dec 3, 2024

Background

#1577 upgraded react-scripts to version 5, along with most other frontend dependencies. After the upgrade, some libraries used in our unit tests are reporting some deprecations.

  • wrapper.find
    Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
    
  • redux configureStore
    The signature '(middlewares?: Middleware<{}, any, Dispatch<AnyAction>>[] | undefined): MockStoreCreator<any, {}>' of 'configureStore' is deprecated.
    

Acceptance Criteria

  • findDOMNode deprecation is resolved
  • configureStore deprecation is resolved
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks

  • Investigate best practices for redux configureStore (possibly consider redux-toolkit)
  • Replace instances of configureStore with best practice where applicable
  • Implement replacement of findDOMNode
  • Run Testing Checklist and confirm all tests past
@jtimpe jtimpe added the dev label Dec 3, 2024
@jtimpe jtimpe changed the title Frontend testing library deprecations Deprecation warnings when running tests - configureStore and findDOMNode Dec 10, 2024
@lhuxraft lhuxraft added Refined Ticket has been refined at the backlog refinement P1 Low Priority - Nice to Have labels Dec 10, 2024
@lhuxraft lhuxraft changed the title Deprecation warnings when running tests - configureStore and findDOMNode Resolve deprecation warnings in unit tests Dec 12, 2024
@lhuxraft lhuxraft removed the P1 Low Priority - Nice to Have label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

No branches or pull requests

2 participants