Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create sprint-25-summary.md #1128

Merged
merged 11 commits into from
Jul 26, 2021
Merged

create sprint-25-summary.md #1128

merged 11 commits into from
Jul 26, 2021

Conversation

amilash
Copy link

@amilash amilash commented Jul 20, 2021

Summary of Changes

Provide a brief summary of changes
Addresses issue #
Acceptance criteria as stated in the issue

How to Test

List the steps to test the PR

Deliverable 1: Accepted Features

Performance Standard(s): At the beginning of each sprint, the Product Owner and development team will collaborate to define a set of user stories to be completed during the sprint. Acceptance criteria for each story will also be defined. The development team will deliver code and functionality to satisfy these user stories.

Acceptable Quality Level: Delivered code meets the acceptance criteria for each user story. Incomplete stories will be assessed and considered for inclusion in the next sprint.

  • Look up the acceptance criteria in the related issue; paste ACs below in checklist format.
  • Check against the criteria:

As facilitator/product manager, @kniz-raft will decide if ACs are met from Raft's perspective.

Deliverable 2: Tested Code

Performance Standard(s): Code delivered under the order must have substantial test code coverage. Version-controlled HHS GitHub repository of code that comprises products that will remain in the government domain.

Acceptable Quality Level: Minimum of 90% test coverage of all code. All areas of code are meaningfully tested.

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?

Deliverable 3: Properly Styled Code

Performance Standard(s): GSA 18F Front- End Guide

Acceptable Quality Level: 0 linting errors and 0 warnings

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Does this PR change any linting or CI settings?

Deliverable 4: Accessible

Performance Standard(s): Web Content Accessibility Guidelines 2.1 AA standards

Acceptable Quality Level: 0 errors reported using an automated scanner and 0 errors reported in manual testing

Deliverable 5: Deployed

Performance Standard(s): Code must successfully build and deploy into the staging environment.

Acceptable Quality Level: Successful build with a single command

NOTE: until we have a proper staging environment this may not be satisfiable prior to merging

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Performance Standard(s): Summary of user stories completed every two weeks. All dependencies are listed and the licenses are documented. Major functionality in the software/source code is documented, including system diagram. Individual methods are documented inline in a format that permits the use of tools such as JSDoc. All non-inherited 800-53 system security controls are documented in the Open Control or OSCAL format and HHS Section 508 Product Assessment Template (PAT) are updated as appropriate.

Acceptable Quality Level: Combination of manual review and automated testing, if available

  • If this PR introduces backend code, is that code documented both inline and overall?
  • If this PR introduces frontend code, is that code documented both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?

Deliverable 7: Secure

Performance Standard(s): Open Web Application Security Project (OWASP) Application Security Verification Standard 3.0

Acceptable Quality Level: Code submitted must be free of medium- and high-level static and dynamic security vulnerabilities

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any security issues?

@amilash amilash added this to the Sprint 25 milestone Jul 20, 2021
@amilash amilash self-assigned this Jul 20, 2021
- updated link to sprint milestone
- added 2 items to blocked
- added next gen ticket and moved to sprint backlog since it is not blocked.
- updated next sprint goals to include UX line item.
- added 'pre qasp' to a few line items in the sprint demo
Copy link
Author

@amilash amilash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes reviewed and updated with next commit.


**Blocked**
- Update ATO docs and corresponding code docs [#962](https://app.zenhub.com/workspaces/tdrs-sprint-board-5f18ab06dfd91c000f7e682e/issues/raft-tech/tanf-app/962)
- SPIKE: File transfer options for Tribal MVP [#1011](https://app.zenhub.com/workspaces/tdrs-sprint-board-5f18ab06dfd91c000f7e682e/issues/raft-tech/tanf-app/1011)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still blocked?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good call. w/ access I think this can be closed?

Copy link
Author

@amilash amilash Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it removed from blocked. @lfrohlich asked me to add it back in. Where do you want it represented?

Actually, this brings up the question- since we changed the ceremonies to be Tuesday, whens our cutoff time for closing the sprint. We can still do it EOD. But workflow wise I usually put these together before the demo- so 'close' it then. LMK. Possibly if we want to close it later, i'll wait to do the notes so we can have fewer edit rounds.
Let me know what you think!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should reflect what is blocked as of the end of the sprint. so if things are unblocked they should be moved in the zenhub board and then wouldn't need to be reflected here. Happy to discuss sequence/timing of sprint summary. Realizing we'll also want to update this at some point: https://github.com/HHS/TANF-app/blob/main/docs/How-We-Work/team-charter/sprint-schedule.md

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of qs

docs/Sprint-Review/sprint-25-summary.md Show resolved Hide resolved
docs/Sprint-Review/sprint-25-summary.md Show resolved Hide resolved
docs/Sprint-Review/sprint-25-summary.md Outdated Show resolved Hide resolved
docs/Sprint-Review/sprint-25-summary.md Outdated Show resolved Hide resolved
docs/Sprint-Review/sprint-25-summary.md Outdated Show resolved Hide resolved
docs/Sprint-Review/sprint-25-summary.md Outdated Show resolved Hide resolved
amilash and others added 6 commits July 21, 2021 13:49
Co-authored-by: Lauren Frohlich <61251539+lfrohlich@users.noreply.github.com>
Co-authored-by: Lauren Frohlich <61251539+lfrohlich@users.noreply.github.com>
Co-authored-by: Lauren Frohlich <61251539+lfrohlich@users.noreply.github.com>
Co-authored-by: Lauren Frohlich <61251539+lfrohlich@users.noreply.github.com>
Co-authored-by: Lauren Frohlich <61251539+lfrohlich@users.noreply.github.com>
added 1059 as per @lfrohlich  request
Copy link
Collaborator

@lfrohlich lfrohlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrew-jameson andrew-jameson merged commit 5bc722d into raft-tdp-main Jul 26, 2021
@andrew-jameson andrew-jameson deleted the amilash-patch-1 branch July 26, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants