Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][backend] rename reports to data files #1159

Closed
wants to merge 3,285 commits into from
Closed

[WIP][backend] rename reports to data files #1159

wants to merge 3,285 commits into from

Conversation

riatzukiza
Copy link

Summary of Changes

Resolves #755

How to Test

List the steps to test the PR

Deliverable 1: Accepted Features

Performance Standard(s): At the beginning of each sprint, the Product Owner and development team will collaborate to define a set of user stories to be completed during the sprint. Acceptance criteria for each story will also be defined. The development team will deliver code and functionality to satisfy these user stories.

Acceptable Quality Level: Delivered code meets the acceptance criteria for each user story. Incomplete stories will be assessed and considered for inclusion in the next sprint.

  • Look up the acceptance criteria in the related issue; paste ACs below in checklist format.
  • Check against the criteria:

As facilitator/product manager, @kniz-raft will decide if ACs are met from Raft's perspective.

Deliverable 2: Tested Code

Performance Standard(s): Code delivered under the order must have substantial test code coverage. Version-controlled HHS GitHub repository of code that comprises products that will remain in the government domain.

Acceptable Quality Level: Minimum of 90% test coverage of all code. All areas of code are meaningfully tested.

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?

Deliverable 3: Properly Styled Code

Performance Standard(s): GSA 18F Front- End Guide

Acceptable Quality Level: 0 linting errors and 0 warnings

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Does this PR change any linting or CI settings?

Deliverable 4: Accessible

Performance Standard(s): Web Content Accessibility Guidelines 2.1 AA standards

Acceptable Quality Level: 0 errors reported using an automated scanner and 0 errors reported in manual testing

Deliverable 5: Deployed

Performance Standard(s): Code must successfully build and deploy into the staging environment.

Acceptable Quality Level: Successful build with a single command

NOTE: until we have a proper staging environment this may not be satisfiable prior to merging

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Performance Standard(s): Summary of user stories completed every two weeks. All dependencies are listed and the licenses are documented. Major functionality in the software/source code is documented, including system diagram. Individual methods are documented inline in a format that permits the use of tools such as JSDoc. All non-inherited 800-53 system security controls are documented in the Open Control or OSCAL format and HHS Section 508 Product Assessment Template (PAT) are updated as appropriate.

Acceptable Quality Level: Combination of manual review and automated testing, if available

  • If this PR introduces backend code, is that code documented both inline and overall?
  • If this PR introduces frontend code, is that code documented both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?

Deliverable 7: Secure

Performance Standard(s): Open Web Application Security Project (OWASP) Application Security Verification Standard 3.0

Acceptable Quality Level: Code submitted must be free of medium- and high-level static and dynamic security vulnerabilities

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any security issues?

jorgegonzalez and others added 30 commits July 16, 2021 15:40
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 7.30.0 to 7.31.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.30.0...v7.31.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [awscli](https://github.com/aws/aws-cli) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/aws/aws-cli/releases)
- [Changelog](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst)
- [Commits](aws/aws-cli@1.20.0...1.20.1)

---
updated-dependencies:
- dependency-name: awscli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ependabot-mass-merge/awscli-1.20.1

Bump awscli from 1.20.0 to 1.20.1 in /tdrs-backend
…frontend/dependabot-mass-merge/eslint-7.31.0

Bump eslint from 7.30.0 to 7.31.0 in /tdrs-frontend
Issue 1051: Add current environment docs and diagrams
Bumps [cypress](https://github.com/cypress-io/cypress) from 7.7.0 to 8.0.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](cypress-io/cypress@v7.7.0...v8.0.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [awscli](https://github.com/aws/aws-cli) from 1.20.1 to 1.20.2.
- [Release notes](https://github.com/aws/aws-cli/releases)
- [Changelog](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst)
- [Commits](aws/aws-cli@1.20.1...1.20.2)

---
updated-dependencies:
- dependency-name: awscli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…ependabot-mass-merge/awscli-1.20.2

Bump awscli from 1.20.1 to 1.20.2 in /tdrs-backend
…frontend/dependabot-mass-merge/cypress-8.0.0

Bump cypress from 7.7.0 to 8.0.0 in /tdrs-frontend
dependabot bot and others added 20 commits August 10, 2021 19:34
Bumps [cypress](https://github.com/cypress-io/cypress) from 8.0.0 to 8.2.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/.releaserc.base.js)
- [Commits](cypress-io/cypress@v8.0.0...v8.2.0)

---
updated-dependencies:
- dependency-name: cypress
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [awscli](https://github.com/aws/aws-cli) from 1.20.16 to 1.20.18.
- [Release notes](https://github.com/aws/aws-cli/releases)
- [Changelog](https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst)
- [Commits](aws/aws-cli@1.20.16...1.20.18)

---
updated-dependencies:
- dependency-name: awscli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…aft-tdp-main/awscli-1.20.18

Bump awscli from 1.20.16 to 1.20.18 in /tdrs-backend
…frontend/raft-tdp-main/cypress-8.2.0

Bump cypress from 8.0.0 to 8.2.0 in /tdrs-frontend
Issue 907: Add client-side Content Security Policy to mitigate XSS
Fix line ending inconsistencies for Zap Scan HTML Report markdown
…entry_content_type.py

Co-authored-by: John Willis <jtwillis92@gmail.com>
@riatzukiza riatzukiza reopened this Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1159 (c36edb9) into main (e37beef) will decrease coverage by 0.97%.
The diff coverage is n/a.

❗ Current head c36edb9 differs from pull request most recent head 17b0230. Consider uploading reports for the commit 17b0230 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   99.12%   98.14%   -0.98%     
==========================================
  Files          32       38       +6     
  Lines         457      917     +460     
  Branches       28       42      +14     
==========================================
+ Hits          453      900     +447     
- Misses          3       12       +9     
- Partials        1        5       +4     
Flag Coverage Δ
dev-backend 98.14% <ø> (?)
main-backend ?
main-frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tdrs-backend/tdpservice/backends.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/clients.py 83.78% <ø> (ø)
tdrs-backend/tdpservice/core/admin.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/core/apps.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/core/models.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/core/views.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/reports/admin.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/reports/apps.py 100.00% <ø> (ø)
tdrs-backend/tdpservice/reports/errors.py 66.66% <ø> (ø)
tdrs-backend/tdpservice/reports/models.py 100.00% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37beef...17b0230. Read the comment docs.

@riatzukiza riatzukiza closed this Aug 17, 2021
@ADPennington ADPennington reopened this Aug 17, 2021
@jtwillis92
Copy link

This looks to be invalid and was supersed by #1160

@jtwillis92 jtwillis92 closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants