-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/1545 (part 2) Setup deployment for live comms site #1548
Feat/1545 (part 2) Setup deployment for live comms site #1548
Conversation
Codecov Report
@@ Coverage Diff @@
## raft-tdp-main #1548 +/- ##
==============================================
Coverage 97.58% 97.58%
==============================================
Files 80 80
Lines 1901 1901
Branches 249 249
==============================================
Hits 1855 1855
Misses 22 22
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
32acde1
to
5823f7d
Compare
Add to main readme documentation about the live-comms static app |
Remove top nav |
…s link, fixes paragraph width
live-comms/August-2021-Update.html
Outdated
@@ -54,7 +54,7 @@ | |||
<div class="usa-navbar"> | |||
<div class="usa-logo" id="basic-logo"> | |||
<em class="usa-logo__text"> | |||
<a href="#main-content" title="TDP Project Updates"> | |||
<a href="/index.html" title="TDP Project Updates"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riatzukiza can you confirm that this line of code reflects the change you mentioned in tabletop?
live-comms/README.md
Outdated
@@ -1 +1,23 @@ | |||
# Design Environment for web hosted live comms | |||
|
|||
The live comms website is for communicating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reitermb could you add a suggestion here that includes more description of the site?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ADPennington Just committed a small update including a few changes there Aaron and I co-worked that got lost somewhere along the line.
… details to 'readme'
live-comms/June-2021-Update.html
Outdated
<span>August 2021</span> | ||
</a> | ||
</li> | ||
<li class="usa-nav__primary-item"> | ||
<a href="June-2021-Update" class="usa-current" aria-current="page"> | ||
<a href="June-2021-Update.html" class="usa-current" aria-current="page"> | ||
<span>August 2021</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<span>August 2021</span> | |
<span>June 2021</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riatzukiza @reitermb one suggestion below before this is ready to go. looks great!
@ttran-hub this is the PR that's in sync with the test environment version I sent your way if you'd like to add any review here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @riatzukiza @reitermb @ttran-hub 👍🏾
Summary of Changes
blocked until #1555 has been merged
In order to actually deploy the site, we needed to set up a cloud foundry deployment script, a manifest file, and make changes to the circle CI config. There are also some small adjustments that have to be made to the HTML files in order for them to find resources.
Pull request closes #1545
Acceptance criteria as stated in the issue
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverable 1: Accepted Features
As Product Owner, @lfrohlich will decide if ACs are met.
Deliverable 2: Tested Code
Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: Context