-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (470): Script commands for development operations #1549
Conversation
commands.sh
Outdated
cd .. | ||
} | ||
# Run eslint against frontend source from frontend container | ||
tdrs-lint-frontend() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do I need installed locally?
$ tdrs-lint-frontend
Creating network "tdrs-frontend_local" with driver "bridge"
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module '/home/node/app/bash'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was running the linter inside of the container when we usually weren't doing that.
Co-authored-by: Andrew <84722778+abottoms-coder@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## raft-tdp-main #1549 +/- ##
==============================================
Coverage 97.58% 97.58%
==============================================
Files 80 80
Lines 1901 1901
Branches 249 249
==============================================
Hits 1855 1855
Misses 22 22
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@msohanifr @riatzukiza Before COB today, please write an update/summary comment detailing work finished and still to-do here. I don't believe most of my comments were addressed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @raftmsohani @riatzukiza 🚀
Summary of Changes
The pull request adds a script file containing commands necessary for development.
Pull request closes #470
Acceptance criteria as stated in the issue
Note: This PR DOES NOT affect backend/frontend code and is solely for standardizing the development tools.
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
And test commands listed in the .sh file.
source commands.sh
470-demo.mp4
Deliverable 1: Accepted Features
As Product Owner, @lfrohlich will decide if ACs are met.
Deliverable 2: Tested Code
n/a: DX
Deliverable 3: Properly Styled Code
n/a: DX
Deliverable 4: Accessible
n/a: DX
Deliverable 5: Deployed
n/a: DX
Deliverable 6: Documented
n/a: DX but well-documented
Deliverable 7: Secure
n/a: DX
Deliverable 8: Context