Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pa11y-ci from 2.4.2 to 3.0.1 in /tdrs-frontend #1573

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jan 25, 2022

Summary of Changes

Provide a brief summary of changes
Pull request closes #1582

Acceptance criteria as stated in the issue

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • [insert ACs here]
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@dependabot dependabot bot added a11y-review PR is ready for accessibility review dependencies Pull requests that update a dependency file dev frontend raft review This issue is ready for raft review labels Jan 25, 2022
@dependabot dependabot bot requested a review from a team January 25, 2022 17:04
@jorgegonzalez
Copy link

@dependabot rebase

Bumps [pa11y-ci](https://github.com/pa11y/ci) from 2.4.2 to 3.0.1.
- [Release notes](https://github.com/pa11y/ci/releases)
- [Changelog](https://github.com/pa11y/pa11y-ci/blob/master/CHANGELOG.md)
- [Commits](pa11y/pa11y-ci@2.4.2...3.0.1)

---
updated-dependencies:
- dependency-name: pa11y-ci
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tdrs-frontend/raft-tdp-main/pa11y-ci-3.0.1 branch from 61afc17 to 10feb51 Compare January 28, 2022 15:47
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #1573 (b2255b4) into raft-tdp-main (94b3f6d) will not change coverage.
The diff coverage is n/a.

❗ Current head b2255b4 differs from pull request most recent head f821b6d. Consider uploading reports for the commit f821b6d to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           raft-tdp-main    #1573   +/-   ##
==============================================
  Coverage          97.58%   97.58%           
==============================================
  Files                 80       80           
  Lines               1901     1901           
  Branches             249      249           
==============================================
  Hits                1855     1855           
  Misses                22       22           
  Partials              24       24           
Flag Coverage Δ
dev-backend 99.10% <ø> (ø)
dev-frontend 94.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b3f6d...f821b6d. Read the comment docs.

@riatzukiza riatzukiza force-pushed the dependabot/npm_and_yarn/tdrs-frontend/raft-tdp-main/pa11y-ci-3.0.1 branch from 4d0efc7 to f8d6eb9 Compare January 28, 2022 17:11
This reverts commit a64e166.
@jorgegonzalez jorgegonzalez removed the a11y-review PR is ready for accessibility review label Jan 28, 2022
@jorgegonzalez jorgegonzalez added Ready to Merge and removed raft review This issue is ready for raft review labels Jan 28, 2022
@jorgegonzalez jorgegonzalez merged commit b6d4d29 into raft-tdp-main Jan 28, 2022
@jorgegonzalez jorgegonzalez deleted the dependabot/npm_and_yarn/tdrs-frontend/raft-tdp-main/pa11y-ci-3.0.1 branch January 28, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file dev frontend Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade pa11y to 3.0.1
2 participants