-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devops/2337 deploy develop on pr merge #2401
Devops/2337 deploy develop on pr merge #2401
Conversation
…h additional job of running e2e tests on deployed environment
…e been run in PR to develop) and temporarily change branch tracked for develop env
…for develop deploys
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2401 +/- ##
========================================
Coverage 92.34% 92.34%
========================================
Files 175 175
Lines 3854 3854
Branches 347 347
========================================
Hits 3559 3559
Misses 220 220
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
"CYPRESS_TOKEN" | ||
"DJANGO_CONFIGURATION" | ||
"DJANGO_DEBUG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these added to CircleCI env vars? Having missing/empty env vars has given us problems in the past.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CYPRESS_TOKEN is already in there, yes. It's actually being used to populate the CYPRESS_TOKEN below. DJANGO_DEBUG is also in there, but I'm not trying to grab it, instead just explicitly setting to "yes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @George-Hudson 👍🏾
Summary of Changes
This tracks pushes to the
develop
branch and triggers a build and deploy to the develop environment, followed by kicking off Cypress end to end integration testing against the newly deployed envPull request closes #2337
How to Test
This will set up a deployment pipeline that only tracks the develop branch
Future tests for this will be when a PR merge (Including this one) kicks off a build, deploy, and test pipeline.
To test the functionality prior to this PR, instead of tracking the
develop
branch, thisdevops/2337-deploy-develop-on-pr-merge
was put in as a placeholder, but still deployed to the develop environment.This GitHub Action kicked off the CircleCI Pipeline. Tests against the newly deployed environment can be seen as part of that pipeline
The tracked branch was changed to
develop
before initiating this PR. The deploy and e2e tests were not kicked off but when this PR is merged, a corresponding GitHub Action and CircleCI build should immediately start.Deliverables
This is part of a larger initiative to refine Continuous Integration and Continuous Deployment pipelines to improve developer quality of life, confidence in higher level deployments (staging and production), and enabling safe, secure, and granular updates to the live assets
Deliverable 1: Accepted Features
Checklist of ACs:
develop
GitHub Actions kicks off a CircleCI pipelinelfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
This PR does not include frontend or backend changes and the app should function identically as before. The process should be continuously monitored by interested parties to look for improvements or breaking pipelines.
Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
This PR used existing tools and scripts and no research was done.
Future research should look at creating: