-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error categories guide #2907
Error categories guide #2907
Conversation
@ADPennington Minor update to the description of #2845 to reflect cat 5,6 examples coming at a later date and spun up a PR. Should be good for review! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2907 +/- ##
===========================================
- Coverage 93.50% 93.47% -0.04%
===========================================
Files 268 269 +1
Lines 6190 6219 +29
Branches 528 530 +2
===========================================
+ Hits 5788 5813 +25
- Misses 309 313 +4
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
@ADPennington I took another pass to tackle the comments! We have an on-deck discussion item to talk through Tribal T7 re: friendly name #2801 work I believe but I've erred on the side of matching the record type guide to what's in the codebase for the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reitermb made a few more suggestions
Co-authored-by: Alex P. <63075587+ADPennington@users.noreply.github.com>
Co-authored-by: Alex P. <63075587+ADPennington@users.noreply.github.com>
Committed! + a tweak to link to both the knowledge center guidance (note that the link won't work until that merges) and the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary of Changes
Adds error categories guide