Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error categories guide #2907

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Error categories guide #2907

merged 9 commits into from
Apr 3, 2024

Conversation

reitermb
Copy link

Summary of Changes

Adds error categories guide

@reitermb
Copy link
Author

@ADPennington Minor update to the description of #2845 to reflect cat 5,6 examples coming at a later date and spun up a PR. Should be good for review!

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (e120f9d) to head (ef6f44f).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2907      +/-   ##
===========================================
- Coverage    93.50%   93.47%   -0.04%     
===========================================
  Files          268      269       +1     
  Lines         6190     6219      +29     
  Branches       528      530       +2     
===========================================
+ Hits          5788     5813      +25     
- Misses         309      313       +4     
  Partials        93       93              
Flag Coverage Δ
dev-backend 93.63% <ø> (-0.05%) ⬇️
dev-frontend 92.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a062d8...ef6f44f. Read the comment docs.

@reitermb reitermb requested a review from ADPennington March 29, 2024 20:42
@reitermb
Copy link
Author

@ADPennington I took another pass to tackle the comments! We have an on-deck discussion item to talk through Tribal T7 re: friendly name #2801 work I believe but I've erred on the side of matching the record type guide to what's in the codebase for the moment.

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reitermb made a few more suggestions

reitermb and others added 4 commits April 3, 2024 12:28
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
Co-authored-by: Alex P.  <63075587+ADPennington@users.noreply.github.com>
@reitermb reitermb requested a review from ADPennington April 3, 2024 16:30
@reitermb
Copy link
Author

reitermb commented Apr 3, 2024

@reitermb made a few more suggestions

Committed! + a tweak to link to both the knowledge center guidance (note that the link won't work until that merges) and the PR

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@reitermb reitermb merged commit eb08f12 into develop Apr 3, 2024
16 checks passed
@reitermb reitermb deleted the error-categories-guide branch April 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants