TANF S3/S4 Total Number of Families Validator Update

[elipe17]

Summary of Changes

Updated the "Total number of families" validators for TANF section 3 and 4 records to not include 0 in their range.
Pull request closes #3088

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up

1. Open http://localhost:3000/ and sign in.
2. Submit tanf_section4_with_errors.txt and verify it generates an out of range error for FAMILIES_MONTH
3. You can also update the NUM_FAMILIES field in ADS.E2J.FTP3.TS06 and submit it to test the boundaries

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• Family totals parsing for >=1 rather than 0
• Testing Checklist has been run and all tests pass
• README is updated, if necessary

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • If this PR introduces backend code changes, are they meaningfully tested?
  • If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• Are backend code style checks passing on CircleCI?
• Are frontend code style checks passing on CircleCI?
• Are code maintainability principles being followed?

Deliverable 4: Accessible

• Does this PR complete the epic?
• Are links included to any other gov-approved PRs associated with epic?
• Does PR include documentation for Raft's a11y review?
• Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• Does this PR provide background for why coding decisions were made?
• If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces dependencies, are their licenses documented?
• Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• Does the OWASP Scan pass on CircleCI?
• Do manual code review and manual testing detect any new security issues?
• If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• the purpose of the research
• methods used to conduct the research
• who participated in the research
• what was tested and how
• impact of research on TDP
• (if applicable) final design mockups produced for TDP development

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (5ae9dd2) to head (72617c1).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3185   +/-   ##
========================================
  Coverage    91.61%   91.61%           
========================================
  Files          291      291           
  Lines         8075     8075           
  Branches       757      757           
========================================
  Hits          7398     7398           
  Misses         594      594           
  Partials        83       83           

Flag	Coverage Δ
dev-backend	91.09% <ø> (ø)
dev-frontend	95.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...-backend/tdpservice/parsers/schema_defs/tanf/t6.py	100.00% <ø> (ø)
...-backend/tdpservice/parsers/schema_defs/tanf/t7.py	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e7848...72617c1. Read the comment docs.

[raftmsohani]

LGTM!

[ADPennington]

@elipe17 lgtm! 🚀 cc: @klinkoberstar @ttran-hub

Summary

• TANF Section 3:
  • errors about 0 values for total family-related data elements included in feedback rpt
  • month-level records with 0 reported total families still added to db (note: not usable, but for another ticket to cleanup)
• TANF Section 4:
  • errors about 0 values for total family-related data elements included in feedback rpt
  • 0-filled month-level records still added to db (note: not usable, but for another ticket to cleanup)

section 3

test_agg_FY22Q1_3185.txt

results (before)

results (after)

---

section 4

test_stratum_FY22Q1_3185.txt

results (before)

results (after)