-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLG Cloud.gov #3192
PLG Cloud.gov #3192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3192 +/- ##
===========================================
+ Coverage 90.65% 91.52% +0.86%
===========================================
Files 299 297 -2
Lines 8490 8415 -75
Branches 794 608 -186
===========================================
+ Hits 7697 7702 +5
+ Misses 676 603 -73
+ Partials 117 110 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- update volume mount - update promtail to scrape new location - update backend log file location
- Remove docker container scrape config
- Testing running bogus command for nginx
export GF_DATABASE_NAME=grafana | ||
export GF_DATABASE_USER=$(echo $VCAP_SERVICES | jq -r '."aws-rds"[0].credentials.username') | ||
export GF_DATABASE_PASSWORD=$(echo $VCAP_SERVICES | jq -r '."aws-rds"[0].credentials.password') | ||
wget https://dl.grafana.com/oss/release/grafana-11.2.0.linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #3232 for this.
@elipe17 can you remind me: is there a relationship between this PR and #3199? I see some file changes here that bump-up RAM resources, so I'd like to have OCIO approval before we increase costs if possible. reference to our questions |
@ADPennington, There is a relationship between this and the ADR. The ADR provides a brief "why" with respect to the introduction of PLG and where it lives in the boundary diagram. The ADR does not cover the cost with respect to RAM for PLG, that could definitely be added. There is not any increase in RAM allocation for existing apps (frontend/backend/etc). However, I did provide general "guestimates" of the RAM needed for PLG to run smoothly while monitoring all of our deployments. That number is an aggregate needed for PLG in it's entirety and it is not required per space or anything like that. As an absolute maximum we would be looking at 10GB of memory and 3.5GB on the lowest end. I am pretty confident we will skew towards the low end. Just need to do some maths and better estimations to figure it out. |
@ADPennington I also wanted to add that merging this wont incur any new cost. Everything is already deployed in the dev space with the resources we currently have. The cost implications will come into question when 3222 is worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…into 3046-plg-cloud
Below are my true calculations for the required memory to deploy PLG in production. Prometheus is scraping about 2400 series from our dev environment. You can determine this by logging into Grafana and querying the For Loki, we don't have as nice of a tool and we have to do a little bit of estimation. On my local machine, at rest with no logging or log querying happening Loki consumes ~100MB of memory. When parsing a 50MB file with logging set to it's most verbose setting (the case in dev/staging), and Grafana querying for new logs every 5 seconds (as fast as it will go), Loki's memory consumption peaked at ~250MB. With that in mind, when Loki is receiving logs from all environments there is a possibility that it's memory could increase by a factor of at least 6 (for each backend app). The likelihood of that all backend apps are parsing files at the same time is very low. But there is a good chance one backend app from each environment could parse a hefty file at the same time. With that said, starting Loki with a memory usage of 1GB would be my recommendation. We should also keep in mind that there are use cases that cause Loki memory consumption to grow without bounds. I was able to produce this locally and is something for future consideration. For Grafana, no matter what I did in the deployed or local environment it's consumption never breached 150MB. Grafana's documentation also suggests that the minimum memory should be set at 512MB which is how it is configured in this PR and is my recommended configuration. Including the Promtail deployments and the Postgres exporters we should expect a initial total memory requirement for PLG to be 2.5GB: Because all of these apps are stateless, we can always scale their memory up or down as we learn more and more about their needs with respect to our workloads while they are deployed. |
* pypi cfg for nexus * Changes for docker/apt install * new registry in package-lock * anonymous curl works better, auth fails * remove kib-dash, made backend-back use bash in task file * change backend system to buster * Postgres buster not available. Upgrade everything to bullseye * Merge thought to intentionally remove prometheus. Fixing pipfiles * typo * Cleanup of exploratory cf-check code * cleanup pt2 cf-check --------- Co-authored-by: andrew-jameson <ajameson@teamraft.com>
1414394
to
4fec7f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pairing on review @elipe17 🚀
- RAM quota updated in org, so we can bump when needed
- uid is not a secret
- let's check the zap scan results next week (after this merges) to see if it catches anything related to header settings
Summary of Changes
Pull request closes #3046
Considerations:
We can/should hook Grafana up to our RDS to have a more persistent set of datasources, dashboards, etc...Need to verify logs in Loki are queryable from days, weeks, months, etc agoHow to Test
PLG is deployed in the dev environment for the moment. If you would like to browse Grafana I have opened a public route to it for the interim until we decide where PLG is going to live. Reach out to me for username and password. Once you're logged in, feel free to browse the dashboards. Note, the
Logs
dashboard only has logging information as far back as 09/25/2024 at ~9:40am ET since that is when promtail had it's first successful exports.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):