-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3180 - error type field #3202
3180 - error type field #3202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3202 +/- ##
========================================
Coverage 92.66% 92.66%
========================================
Files 47 47
Lines 1009 1009
Branches 169 169
========================================
Hits 935 935
Misses 42 42
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this is in great shape @jtimpe 🥇 -- approval coming up tomorrow. I'd just like to firm up release note next steps with UX team at our sync tmor morning before this closes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appreciate the quick change @jtimpe 👍🏾
- Evidence of the updated error report is here
- Really nice to see that this change applies to new and previously-generated error reports, so resubmission or reparsing command isn't needed to access the error type.
- I'm hopeful that the release notes, KC guidance, and UX research can help inform if the error type "friendly names" are easy-to-understand. As is, I think we should expect clarifying questions, which is 🆗 for now. cc: @klinkoberstar @ttran-hub @victoriaatraft @reitermb
Summary of Changes
Pull request closes #3180
How to Test
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):