Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document session management strategy #364

Merged
merged 7 commits into from
Jan 4, 2021

Conversation

carltonsmith
Copy link

This pull request changes...

Copy link

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document looks good to me. Before closing out #282 I think #197 needs to get tasks added to it.

Copy link

@alexsoble alexsoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice there's a question mark here:

When the FE timer reaches 20 minutes (?) ...

Do we need input from design or someone else to confirm 20 minutes as a reasonable starting point? Seems like a reasonable starting point to me, and easy enough to adjust if needed.

@carltonsmith
Copy link
Author

Yes. I'll remove the question mark, but we can adjust if necessary.

I notice there's a question mark here:

When the FE timer reaches 20 minutes (?) ...

Do we need input from design or someone else to confirm 20 minutes as a reasonable starting point? Seems like a reasonable starting point to me, and easy enough to adjust if needed.

@carltonsmith
Copy link
Author

I'm not sure I understand. 282 is a blocker for 197, but how would we add 197 to 282?

Document looks good to me. Before closing out #282 I think #197 needs to get tasks added to it.

removed question mark
@rahearn
Copy link

rahearn commented Oct 23, 2020

I'm not sure I understand. 282 is a blocker for 197, but how would we add 197 to 282?

Sorry, my sentence could have used an editor or two. I mean that the AC for 282 says that tasks are documented inside 197. Merging this PR will automatically close 282, so I want to be sure we don't forget to actually write out the tasks inside 197 before that happens.

@carltonsmith
Copy link
Author

Sorry about that. I misunderstood what you were saying. 197 is now tasked out.

I'm not sure I understand. 282 is a blocker for 197, but how would we add 197 to 282?

Sorry, my sentence could have used an editor or two. I mean that the AC for 282 says that tasks are documented inside 197. Merging this PR will automatically close 282, so I want to be sure we don't forget to actually write out the tasks inside 197 before that happens.

@alexsoble alexsoble mentioned this pull request Nov 18, 2020
7 tasks
carltonsmith and others added 5 commits November 18, 2020 16:42
…t-tech/TANF-app into documentation/282/session-management

� Conflicts:
�	tdrs-backend/docs/session-management.md
For some reason, `throttle` in `react-idle-timer` package was not working correctly when trying to dispatch an action. `Debounce` does work as expected.
Added where timeout is set and removed a question mark
@carltonsmith carltonsmith merged commit fe34eb1 into raft-tdp-main Jan 4, 2021
@carltonsmith carltonsmith deleted the documentation/282/session-management branch January 4, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] As a user, I need to be timed out from my session (Research session timeout)
4 participants