Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 416: [Frontend] Add a download button to the Data Files view #859
Issue 416: [Frontend] Add a download button to the Data Files view #859
Changes from 10 commits
73e3fff
2b297d3
f2b86d4
d96f7cc
e0a2954
535c0f4
8e0589a
f4c25de
7d53cba
4a0ab29
25427cf
3ed20a9
e2558c3
4a9243c
6477607
c0a1dd2
9a07163
bdda507
0440dbc
f8a9b5a
5064b53
6afdf22
b33b966
5c58fa7
f8e0454
a3c5951
f7eb3a0
7ca265a
4f8eb1f
56944c8
c0afefe
2bd2158
059df39
17e408a
8edb851
10df056
8110676
8e2eac8
144f19e
389eb11
38db273
ce30850
eec70f1
a56e640
5a2d6c7
25dfba6
e447012
a36c0b7
b36c038
16811c5
e7c5afc
94553be
c74b23c
f9de1bb
8be2003
85b3911
05710a6
c6ae760
151443d
6570ba5
879304a
3b45379
49975d9
e8df394
09a8aa9
9dd7d00
92d237e
7983e0c
d9438a9
21b2188
e5a6780
c6f86b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may not be worthy of an entire issue, but when I was working through this I saw this code and it seems to me like like this is the sort of thing django should be handling before the data ever gets to the react UI.
I am open to thoughts on if/how we should deal with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be removing Federal Government from the options list? If so, I definitely agree it should be done by the backend based on the permissions of the person requesting. Also, it doesn't appear to work because I still see the option for "Federal Government" in both the STT combobox on the upload form and the Profile page.
I'd think a separate issue would be warranted to implement that correctly on the backend. The only people who should see that are OFA admins as far as I know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree. i'd only expect to see fedgov on the frontend request access and backend profile comboboxes because this is the expected STT for any OFA staff (sys admin, ofa admin, ofa data analyst, regional). good to set this up so that these user groups cannot upload/download on behalf of that STT (e.g. when profile STT = fedgov, data files STT != fedgov)