Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix yarn/npm workspaces (No code changes) #71

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix yarn/npm workspaces (No code changes) #71

merged 1 commit into from
Oct 25, 2022

Conversation

RubenPX
Copy link
Contributor

@RubenPX RubenPX commented Oct 22, 2022 •
edited
Loading

Currently in draft because i'm testing a lot of npm comands

This will fix yarn workspaces

Reference: https://classic.yarnpkg.com/lang/en/docs/workspaces/#toc-tips-tricks

advantages: All node_modules will stay in root folder

@RubenPX RubenPX changed the title fix yarn/npm workspaces fix yarn/npm workspaces (No code changed) Oct 22, 2022
@RubenPX RubenPX changed the title fix yarn/npm workspaces (No code changed) fix yarn/npm workspaces (No code changes) Oct 22, 2022
@RubenPX RubenPX marked this pull request as draft October 22, 2022 13:34
@RubenPX
Copy link
Contributor Author

RubenPX commented Oct 22, 2022 •
edited
Loading

bcrypt get's frezed when i run yarn command
image

Only get's fixed when restart yarn install

bcrypt issue: kelektiv/node.bcrypt.js#665

pull request: kelektiv/node.bcrypt.js#890

@RubenPX
Copy link
Contributor Author

RubenPX commented Oct 24, 2022

Not ready to merged

Only ready when bcrypt issue has been resolved

@KryptoPX
Copy link
Contributor

Confirmed, in version 5.2.0 of bcrypt package this issue will be fixed

@srgooglo srgooglo marked this pull request as ready for review October 25, 2022 22:52
@srgooglo srgooglo merged commit 5bdb882 into ragestudio:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenPX @KryptoPX @srgooglo