Skip to content

Commit

Permalink
Fix problem filter scope wording
Browse files Browse the repository at this point in the history
* use "selected elements" instead of "selected element" in all
implementations
* use "their children" due to the plural form of "elements"
* remove double blank in working set related scope
  • Loading branch information
Bananeweizen authored and mickaelistria committed Aug 25, 2023
1 parent ffb0cdc commit 81e7679
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static FileTextSearchScope newWorkspaceScope(String[] fileNamePatterns, b
* @param roots the roots resources defining the scope.
* @param fileNamePatterns file name pattern that all files have to match <code>null</code> to include all file names.
* @param includeDerived defines if derived files and files inside derived containers are included in the scope.
* @return a scope containing the resources and its children if they match the given file name patterns.
* @return a scope containing the resources and their children if they match the given file name patterns.
*/
public static FileTextSearchScope newSearchScope(IResource[] roots, String[] fileNamePatterns, boolean includeDerived) {
roots= removeRedundantEntries(roots, includeDerived);
Expand Down
2 changes: 1 addition & 1 deletion bundles/org.eclipse.ui.ide/schema/markerSupport.exsd
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ If this value is not set the value is ON_ANY
<meta.section type="examples"/>
</appinfo>
<documentation>
The following is an example of a problem filter definition in the marker support. This example only shows java warnings on the selected element and its children and filters out those with the String NON-NLS
The following is an example of a problem filter definition in the marker support. This example only shows java warnings on the selected elements and their children and filters out those with the String NON-NLS
&lt;p&gt;
&lt;pre&gt;
&lt;extension point=&quot;org.eclipse.ui.ide.markerSupport&quot;&gt;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ filtersDialog_showItemsOfType = Show items of &type:
filtersDialog_anyResource = No filter, show all &elements
filtersDialog_anyResourceInSameProject = On elements in selected pro&jects
filtersDialog_selectedResource = On selected ele&ments only
filtersDialog_selectedAndChildren = On selected elements and its c&hildren
filtersDialog_workingSet = On wor&king set: {0}
filtersDialog_selectedAndChildren = On selected elements and their c&hildren
filtersDialog_workingSet = On wor&king set: {0}
filtersDialog_currentWorkingSet = On selected wor&king set
filtersDialog_workingSetSelect = &Select...
filtersDialog_noWorkingSet = On wor&king set: <no working set selected>
filtersDialog_noWorkingSet = On wor&king set: <no working set selected>
filtersDialog_selectAll = Select &All
filtersDialog_deselectAll = &Deselect All
filtersDialog_selectAllTypes = Sele&ct All
Expand Down Expand Up @@ -238,8 +238,8 @@ ProblemFilterDialog_Contains_Description = On any description containing {0}
ProblemFilterDialog_Does_Not_Contain_Description = On any description not containing {0}
ProblemFilterDialog_any = Filter on any element
ProblemFilterDialog_sameContainer = Filter on any in the same container
ProblemFilterDialog_selectedAndChildren = Filter on selected element and its children
ProblemFilterDialog_selected = Filter on selected element only
ProblemFilterDialog_selectedAndChildren = Filter on selected elements and their children
ProblemFilterDialog_selected = Filter on selected elements only
ProblemFilterDialog_workingSet = Filter on working set {0}

ProblemFilterRegistry_nullType = Marker type {0} referenced in {1} does not exist.
Expand Down

0 comments on commit 81e7679

Please sign in to comment.