Add support to handle 404 and 405 http error code in OTLP exporter op…

…en-telemetry#5827
rahuldimri · Aug 5, 2022 · 72a0f1f · 72a0f1f
1 parent ba6fe5a
commit 72a0f1f
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,7 @@
 
 - Bump to opentelemetry-proto v0.19.0. (#5823)
 - Expose `Scope.Attributes` in pdata (#5826)
+- Add support to handle 404, 405 http error code as permanent errors in OTLP exporter (#5827)
 
 ### 🧰 Bug fixes 🧰
 

diff --git a/exporter/otlphttpexporter/otlp.go b/exporter/otlphttpexporter/otlp.go
@@ -201,6 +201,10 @@ func isPermanentClientFailure(code int) bool {
 		return true
 	case http.StatusRequestHeaderFieldsTooLarge:
 		return true
+	case http.StatusNotFound:
+		return true
+	case http.StatusMethodNotAllowed:
+		return true
 	default:
 		return false
 	}

diff --git a/exporter/otlphttpexporter/otlp_test.go b/exporter/otlphttpexporter/otlp_test.go
@@ -402,7 +402,14 @@ func TestErrorResponses(t *testing.T) {
 		{
 			name:           "404",
 			responseStatus: http.StatusNotFound,
-			err:            errors.New(errMsgPrefix + "404"),
+			err:            status.New(codes.InvalidArgument, "Bad field"),
+			isPermErr:      true,
+		},
+		{
+			name:           "405",
+			responseStatus: http.StatusMethodNotAllowed,
+			err:            status.New(codes.InvalidArgument, "Bad field"),
+			isPermErr:      true,
 		},
 		{
 			name:           "413",