Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do contract calls on unconfirmed blocks #239

Closed
palango opened this issue Apr 8, 2019 · 1 comment
Closed

Do contract calls on unconfirmed blocks #239

palango opened this issue Apr 8, 2019 · 1 comment
Assignees
Labels
Enhancement 🌟 New feature or request MS 👀 Related to the Monitoring Service PFS 🚀 Related to the Pathfinding Service
Milestone

Comments

@palango
Copy link
Contributor

palango commented Apr 8, 2019

Currently we do calls to contracts (like the deposit of a user in the UDC) based on the latest block.

Instead we should take the lowest of all blocks from the last confirmed until the latest block.

@palango palango added Enhancement 🌟 New feature or request MS 👀 Related to the Monitoring Service PFS 🚀 Related to the Pathfinding Service labels Apr 8, 2019
@palango palango added this to the Ithaca milestone Jun 24, 2019
@palango palango changed the title Do contract calls on confirmed blocks Do contract calls on unconfirmed blocks Jul 29, 2019
@karlb karlb self-assigned this Aug 5, 2019
@karlb
Copy link
Contributor

karlb commented Aug 6, 2019

For the PFS this is safe, but will force a user to wait until confirmation of his deposit before he can start using a PFS.

For the MS, using unconfimed blocks opens an attack vector. If an attacker can manipulate a single block, a MS can be misled regarding the UDC deposit and will not monitor properly. On the other hand we must make sure that MSs can't be abused to close channels for free.

karlb added a commit to karlb/raiden-services that referenced this issue Aug 6, 2019
@karlb karlb mentioned this issue Aug 6, 2019
3 tasks
karlb added a commit that referenced this issue Aug 8, 2019
@karlb karlb closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🌟 New feature or request MS 👀 Related to the Monitoring Service PFS 🚀 Related to the Pathfinding Service
Projects
None yet
Development

No branches or pull requests

2 participants