Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove handling of ChannelDeposit event #494

Closed
palango opened this issue Jul 31, 2019 · 1 comment · Fixed by #496
Closed

Remove handling of ChannelDeposit event #494

palango opened this issue Jul 31, 2019 · 1 comment · Fixed by #496
Assignees
@palango
Labels
Bug 🐛 Something isn't working Enhancement 🌟 New feature or request PFS 🚀 Related to the Pathfinding Service
Milestone
Ithaca

Comments

@palango
Copy link
Contributor

palango commented Jul 31, 2019

I see no point in handling the ChannelDeposit any more. The CapacityUpdates provide all necessary information.

Removing the event handling would allow us to simplify the code and remove corner cases and possible timing issues.
@palango palango added Enhancement 🌟 New feature or request PFS 🚀 Related to the Pathfinding Service labels Jul 31, 2019
@palango
Copy link
Contributor Author

palango commented Jul 31, 2019

This actually causes one bug in the scenario player:

2019-07-31 14:29:34.580800 [info     ] Received ChannelNewDeposit event [pathfinding_service.service] event_={'token_network_address': '0x07ba6a78dF3335D9f923051830e620aEA95691aA', 'channel_identifier': 4, 'participant_address': '0x13F5a5b0dC62343339900c89c51CE20fD9cA019c', 'total_deposit': 5, 'block_number': 1037667, 'type_name': 'ReceiveChannelNewDepositEvent'}
2019-07-31 14:29:34.580973 [debug    ] Calling `update_deposit`       [pathfinding_service.model.channel_view] capacity=5 deposit=0 new_capacity=10 total_deposit=5

Here the event arrives after the CapacityUpdate, but the capacity is still increased.

@palango palango mentioned this issue Jul 31, 2019
Closed
@palango palango added this to the Ithaca milestone Jul 31, 2019
@palango palango self-assigned this Aug 1, 2019
palango added a commit to palango/raiden-services that referenced this issue Aug 1, 2019
@palango
Remove handling of ChannelNewDeposit event
221fb40 
Handling the event turned out to be a source of issues. Besides, it
doesn't provide any advantages over just using the capacity updates from
the nodes.

This commit removes all internal handling of the deposit event.

Fixes raiden-network#494
@palango palango mentioned this issue Aug 1, 2019
Merged
palango added a commit that referenced this issue Aug 1, 2019
@palango
Remove handling of ChannelNewDeposit event
38fdb13 
Handling the event turned out to be a source of issues. Besides, it
doesn't provide any advantages over just using the capacity updates from
the nodes.

This commit removes all internal handling of the deposit event.

Fixes #494
@palango palango added the Bug 🐛 Something isn't working label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palango palango

Labels
Bug 🐛 Something isn't working Enhancement 🌟 New feature or request PFS 🚀 Related to the Pathfinding Service
Projects
None yet
Milestone
Ithaca
Development

Successfully merging a pull request may close this issue.

Remove handling of ChannelNewDeposit event palango/raiden-services
1 participant
@palango