Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to return all online addresses #1010

Merged
merged 1 commit into from
May 17, 2021

Conversation

karlb
Copy link
Contributor

@karlb karlb commented May 17, 2021

This makes it possible to run the Raiden explorer efficiently.

Closes #1007.

This makes it possible to run the Raiden explorer efficiently.

Closes raiden-network#1007.
@karlb karlb requested a review from manuelwedler May 17, 2021 13:21
@auto-assign auto-assign bot requested a review from konradkonrad May 17, 2021 13:21
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #1010 (cadc24b) into master (ce7f75e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   89.06%   89.06%   -0.01%     
==========================================
  Files          42       42              
  Lines        3348     3357       +9     
  Branches      423      425       +2     
==========================================
+ Hits         2982     2990       +8     
  Misses        266      266              
- Partials      100      101       +1     
Impacted Files Coverage Δ
src/pathfinding_service/api.py 95.34% <100.00%> (+0.11%) ⬆️
src/raiden_libs/service_registry.py 80.49% <0.00%> (-0.68%) ⬇️
src/raiden_libs/cli.py 80.00% <0.00%> (ø)
src/pathfinding_service/service.py 92.27% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7f75e...cadc24b. Read the comment docs.

url = api_url + "/v1/online_addresses"
response = requests.get(url)
assert response.status_code == 200
assert response.json() == [to_checksum_address(online_addr)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to want to have n>=2 examples for tests involving a "many" thing, but I guess this is easy enough...

Copy link
Contributor

@konradkonrad konradkonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PFS endpoint all online nodes
3 participants