Update raiden and fix chain_id problems #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful to work around ethereum/web3.py#1677, which prevents the onchain chain_id from matching the web3 chain_id.
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
- Coverage 89.09% 89.06% -0.03%
==========================================
Files 42 42
Lines 3356 3356
Branches 424 424
==========================================
- Hits 2990 2989 -1
- Misses 264 265 +1
Partials 102 102
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chain_id problems have been introduced by usage of the chain_id opcode in the contracts.