Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upper bound for get_pessimistic_udc_balance #1090

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Conversation

palango
Copy link
Contributor

@palango palango commented Oct 4, 2021

  • Fix upper bound of get_pessimistic_udc_balance
  • some minor improvements to remove temporary variables

@palango palango requested a review from fredo October 4, 2021 14:22
@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #1090 (1d895f1) into master (85bc6c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1d895f1 differs from pull request most recent head 2ca88df. Consider uploading reports for the commit 2ca88df to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1090      +/-   ##
==========================================
- Coverage   88.86%   88.85%   -0.01%     
==========================================
  Files          43       43              
  Lines        3450     3447       -3     
  Branches      429      429              
==========================================
- Hits         3066     3063       -3     
  Misses        278      278              
  Partials      106      106              
Impacted Files Coverage Δ
src/monitoring_service/handlers.py 89.59% <ø> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bc6c5...2ca88df. Read the comment docs.

This was not removed when the surrroundiung `range` call was removed.
As this is now the limit, we don't want to increment that here.
@palango palango changed the title Remove unnecessary local variables Fix upper bound for get_pessimistic_udc_balance Oct 4, 2021
@palango palango merged commit 7de128f into master Oct 4, 2021
@palango palango deleted the minor-cleanup branch October 4, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants