Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #1093

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Minor fixes #1093

merged 3 commits into from
Oct 7, 2021

Conversation

palango
Copy link
Contributor

@palango palango commented Oct 7, 2021

See commit descriptions.

This happens for example on a token network registry with no token
networks. The filter will then fallback to querying all events, which
will throw an error when decoding those events.
@palango palango requested a review from karlb October 7, 2021 14:29
@auto-assign auto-assign bot requested a review from fredo October 7, 2021 14:29
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1093 (9c1b997) into master (b7501ff) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   88.83%   88.77%   -0.06%     
==========================================
  Files          43       43              
  Lines        3447     3449       +2     
  Branches      429      430       +1     
==========================================
  Hits         3062     3062              
- Misses        279      280       +1     
- Partials      106      107       +1     
Impacted Files Coverage Δ
src/raiden_libs/blockchain.py 84.21% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7501ff...9c1b997. Read the comment docs.

@karlb karlb merged commit 3cbb76f into raiden-network:master Oct 7, 2021
@palango palango deleted the minor-fixes branch October 7, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants