Fix unintentional creation of defaultdict key by __getitem__ calls #1110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the whitelisting mechanism of the services had a bug:
Several
__getitem__
calls meant to be readonly to the internal defaultdict that tracks the whitelisted user-addresses were unintentionally causing the address being added to the dict with a default-value.This in the end let the address pass the whiltelisting check:
raiden-services/src/raiden_libs/user_address.py
Lines 311 to 312 in 091c6ca
Which can potentially lead to performance issues and heavy load on the matrix servers.
This PR fixes this issue.