Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmed receipts #503

Merged
merged 2 commits into from
Aug 8, 2019
Merged

Conversation

palango
Copy link
Contributor

@palango palango commented Aug 7, 2019

This waits for confirmation blocks before checking the status of pending transactions.

Follow-up for #502

@palango palango requested a review from karlb August 7, 2019 11:22
@palango palango force-pushed the confirmed-receipts branch from 6470730 to ebdb398 Compare August 7, 2019 11:27
This commit adds an additional waiting time before pending transactions
are checked for their status.
@palango palango force-pushed the confirmed-receipts branch from ebdb398 to 0f72671 Compare August 8, 2019 09:44
@palango palango marked this pull request as ready for review August 8, 2019 09:45
src/monitoring_service/service.py Outdated Show resolved Hide resolved
src/monitoring_service/service.py Outdated Show resolved Hide resolved
src/monitoring_service/service.py Outdated Show resolved Hide resolved
src/monitoring_service/service.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #503 into master will decrease coverage by 0.09%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #503     +/-   ##
=========================================
- Coverage   91.22%   91.12%   -0.1%     
=========================================
  Files          36       36             
  Lines        2234     2243      +9     
  Branches      283      285      +2     
=========================================
+ Hits         2038     2044      +6     
- Misses        147      150      +3     
  Partials       49       49
Impacted Files Coverage Δ
src/monitoring_service/service.py 90% <71.42%> (-0.11%) ⬇️
src/pathfinding_service/api.py 94.89% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49892d7...86bac0a. Read the comment docs.

@palango palango force-pushed the confirmed-receipts branch from 1c0ad28 to 86bac0a Compare August 8, 2019 10:05
@palango palango merged commit 0399a04 into raiden-network:master Aug 8, 2019
@palango palango deleted the confirmed-receipts branch August 8, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants