Graph pruning #521
Merged
Graph pruning #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
==========================================
- Coverage 91.23% 91.22% -0.01%
==========================================
Files 36 36
Lines 2258 2269 +11
Branches 287 290 +3
==========================================
+ Hits 2060 2070 +10
Misses 150 150
- Partials 48 49 +1
Continue to review full report at Codecov.
|
Dominik1999
reviewed
Aug 20, 2019
It showed in raiden-network#520 that in bigger token networks the search was blocking the PFS for longer intervals. The main reason for that was that the path finding was trying many routes where participants were offline. This can easily be improved by pruning the graph on unreachable nodes before the routing, so that the graph on which the search is done consists only of reachable nodes. This can be improved further in the future by also pruning channels with to little capacity, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It showed in #520 that in bigger token networks the search was blocking
the PFS for longer intervals. The main reason for that was that the path
finding was trying many routes where participants were offline.
This can easily be improved by pruning the graph on unreachable nodes
before the routing, so that the graph on which the search is done
consists only of reachable nodes.
This can be improved further in the future by also pruning channels with
to little capacity, etc.
Fixes #520