Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FeeUpdate tests #661

Merged
merged 3 commits into from
Nov 27, 2019

Conversation

palango
Copy link
Contributor

@palango palango commented Nov 27, 2019

Until now capacity updates were properly testsed, but not fee updates.

This improves this a bit.

@auto-assign auto-assign bot requested a review from rakanalh November 27, 2019 10:32
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8ec0c2f). Click here to learn what that means.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #661   +/-   ##
=========================================
  Coverage          ?   90.37%           
=========================================
  Files             ?       35           
  Lines             ?     2399           
  Branches          ?      310           
=========================================
  Hits              ?     2168           
  Misses            ?      171           
  Partials          ?       60
Impacted Files Coverage Δ
src/pathfinding_service/exceptions.py 98.5% <100%> (ø)
src/pathfinding_service/model/token_network.py 95.45% <50%> (ø)
src/pathfinding_service/model/channel.py 97.08% <75%> (ø)
src/pathfinding_service/service.py 93.5% <89.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec0c2f...7438e6d. Read the comment docs.

@palango palango requested a review from hackaugusto November 27, 2019 10:34
@palango palango force-pushed the better-fee-update-tests branch 2 times, most recently from 9307e78 to a38c7e0 Compare November 27, 2019 10:43
@palango palango force-pushed the better-fee-update-tests branch from cfd6fcf to f833548 Compare November 27, 2019 12:29
Until now capacity updates were properly testsed, but not fee updates.

This improves this a bit.
@palango palango force-pushed the better-fee-update-tests branch from f833548 to 7438e6d Compare November 27, 2019 14:35
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rakanalh rakanalh merged commit 8dbf0c0 into raiden-network:master Nov 27, 2019
@palango palango deleted the better-fee-update-tests branch November 27, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants