Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide specific error message for common errors #674

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Dec 2, 2019

This should make it easier to known what's going on when we get "no
route found" errors.

This should make it easier to known what's going on when we get "no
route found" errors.
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #674 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   91.18%   91.17%   -0.02%     
==========================================
  Files          35       35              
  Lines        2382     2401      +19     
  Branches      304      313       +9     
==========================================
+ Hits         2172     2189      +17     
- Misses        151      152       +1     
- Partials       59       60       +1
Impacted Files Coverage Δ
src/pathfinding_service/api.py 96.7% <100%> (+0.04%) ⬆️
src/pathfinding_service/model/token_network.py 95.78% <100%> (+0.38%) ⬆️
src/raiden_libs/database.py 88.4% <0%> (-2.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee4d8a...cbe5f92. Read the comment docs.

@karlb karlb marked this pull request as ready for review December 2, 2019 14:43
@auto-assign auto-assign bot requested a review from palango December 2, 2019 14:43
@karlb karlb requested a review from hackaugusto December 2, 2019 14:44
@karlb
Copy link
Contributor Author

karlb commented Dec 2, 2019

@hackaugusto reviewed it on my machine.

@karlb karlb merged commit ab6a625 into raiden-network:master Dec 2, 2019
@karlb karlb deleted the no-route-error-msg branch December 2, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant