Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix channel delete #695

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix channel delete #695

merged 1 commit into from
Jan 9, 2020

Conversation

palango
Copy link
Contributor

@palango palango commented Jan 9, 2020

Merge after #694

This fixes a problem in DB.delete_channel and adds add test for it.

@auto-assign auto-assign bot requested a review from rakanalh January 9, 2020 15:36
@codecov
Copy link

codecov bot commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #695 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   91.25%   91.17%   -0.08%     
==========================================
  Files          35       35              
  Lines        2424     2425       +1     
  Branches      315      315              
==========================================
- Hits         2212     2211       -1     
- Misses        153      155       +2     
  Partials       59       59
Impacted Files Coverage Δ
src/pathfinding_service/database.py 100% <100%> (ø) ⬆️
src/pathfinding_service/api.py 95.12% <0%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1deb47...d7c1f00. Read the comment docs.

rakanalh
rakanalh approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though would have been nice to separate the db -> database renames to a different PR for context clarity.

src/pathfinding_service/database.py
"DELETE FROM channel WHERE token_network_address = ? AND channel_id = ?",
[token_network_address, channel_id],
[to_checksum_address(token_network_address), hex256(channel_id)],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the fix

@palango palango force-pushed the fix-channel-delete branch from d082176 to d7c1f00 Compare January 9, 2020 15:51
@palango palango requested a review from karlb January 9, 2020 15:52
@palango palango merged commit 49380d6 into raiden-network:master Jan 9, 2020
@palango palango deleted the fix-channel-delete branch January 9, 2020 15:55
@palango palango mentioned this pull request Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh rakanalh approved these changes

@karlb karlb Awaiting requested review from karlb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palango @rakanalh