Check for deprecation of SR before withdraw #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Withdraws are allowed immediately if the ServiceRegistry has been deprecated.
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
- Coverage 89.70% 89.64% -0.07%
==========================================
Files 35 35
Lines 2643 2645 +2
Branches 336 336
==========================================
Hits 2371 2371
- Misses 201 203 +2
Partials 71 71
Continue to review full report at Codecov.
|
hackaugusto
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdraws are allowed immediately if the ServiceRegistry has been
deprecated.