Add API to MS #797
Merged
Add API to MS #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, mypy won't find all python files in that directory. This allows us to drop some type ignores and casts which where only necessary due to incomplete type information before.
palango
force-pushed
the
ms-api
branch
2 times, most recently
from
5556295 to
e672c59
Compare
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 90.01% 90.02% +0.01%
==========================================
Files 35 38 +3
Lines 2633 2706 +73
Branches 334 339 +5
==========================================
+ Hits 2370 2436 +66
- Misses 189 193 +4
- Partials 74 77 +3
Continue to review full report at Codecov.
|
karlb
suggested changes
Jun 8, 2020
palango
force-pushed
the
ms-api
branch
2 times, most recently
from
176f30f to
974e2e2
Compare
karlb
approved these changes
Jun 9, 2020
karlb
approved these changes
Jun 9, 2020
palango
force-pushed
the
ms-api
branch
2 times, most recently
from
176e4f5 to
bb3597d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a REST API to the MS.
This is done in preparation for #7 for which we need a working API to export prometheus stats. However, it's also useful for #501, #650 and #763
The changes include:
mypyfixes to changes caused by ne__init__.pyfileMonitoringServiceagreenletMsApiclass with currently only a/infoendpoint similar to the PFS'