Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle raw identifier struct field #14

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix: handle raw identifier struct field #14

merged 1 commit into from
Apr 1, 2022

Conversation

ymgyt
Copy link
Contributor

@ymgyt ymgyt commented Nov 30, 2021

Error

    #[derive(Builder, PartialEq, Debug)]
    pub struct RawIdentifier {
        id: String,
        r#type: String,
    }
error: proc-macro derive panicked
  --> safe-builder/tests/all/mod.rs:45:14
   |
45 |     #[derive(Builder, PartialEq, Debug)]
   |              ^^^^^^^
   |
   = help: message: `"R#typeType"` is not a valid identifier

What does this change?

  • unraw struct field raw identifier before format

What can I check for bug fixes?

  • add minimum test case

Note

Copy link
Member

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bokuweb bokuweb merged commit be5ead2 into raiden-rs:master Apr 1, 2022
@ymgyt ymgyt deleted the raw-identifier branch April 1, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants