Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved to using GitHub hosted macOS ARM build; fixed pip install timeout issue in CIs; ARM tests for python 3.8-3.12 #1

Merged
merged 22 commits into from
Feb 2, 2024

Conversation

andreped
Copy link
Member

@andreped andreped commented Feb 2, 2024

You can squash merge this PR when it is deemed ready to be merged.

@dbouget
Copy link
Contributor

dbouget commented Feb 2, 2024

You have to re-include the ANTs download in the macos arm CI, as there is no pyants available for it.
The current unit test will not trigger any issue as no registration is currently performed, but I could try to use the same unit test as in the RADS backend just for running a single registration (without any maps building) as a sanity check.

@andreped
Copy link
Member Author

andreped commented Feb 2, 2024

I fixed the issue now. Feel free to review my PR again, @dbouget :]

@dbouget dbouget self-requested a review February 2, 2024 13:31
@andreped
Copy link
Member Author

andreped commented Feb 2, 2024

@dbouget Remember to squash merge, if you dont want to clutter your commit history.

@dbouget dbouget merged commit d617ace into raidionics:master Feb 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants