Information pulled from github should not be editable/deleted

[ghost]

• github handle and email have a star i guess for indicating a mandatory field, but i can save without an email address. This happend, because I deleted the email. Might happen, if a candidate wants a different email, deletes it and then forgets to add the new one.
• I'm not sure, if this is wanted, but I can also change the github handle. As I signed in with a specific account I don't know if we want to allow to change this field?
  Same here, I just edited the github account to a different one and could save the application

Possible fix: Github handle used for sign up should not be editable and email should be verified.

[carpodaster]

Hey @Nattivolk - thanks!

The reason behind 1) is that a User record is indeed created w/o an email address at first: the rest gets pull from the GH API asynchronously. We should improve that, though. A validation context should fix that: the easy win would be to allow a User to created w/o an email address, just not updated

2. Making the GH-handle of a created User immutable sounds like a really good idea!

[izuroxx]

hi @carpodaster! is this what you have in mind? (github_handle taken out of the params, field disabled; validation on email)

[carpodaster]

Hey @izuroxx. Yes, looks good! The email validation should only kick it when updating the record though (for reasons stated above). But we can discuss / check on that in a PR.

[izuroxx]

@carpodaster there's one more thing :) - while finding all occurrences of Github_handle fields, I also found them in /teams/:id/edit, and also editable - you can change team members through changing the g_h field - would you like those fields to be disabled, too?

[hola-soy-milk]

@izuroxx I think these should be left as editable so that students for example can add their team members. I hope I understood correctly

[emcoding]

I think Ramon is right, as far as teams in current season are concerned. Then again, I can edit everything in my team from last year. Maybe we should 'freeze' team info from previous seasons. Or is that a problem, @anikalindtner @carpodaster ?

[carpodaster]

@izuroxx fixed the github_handle mutability! 🎊

[emcoding]

Can we extract a new issue, with only the first checkbox? @carpodaster

[carpodaster]

@f3pix let‘s do it!

[emcoding]

Closing this. The leftover checkbox nr 1 is moved to #885.