Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3 to build matrix #162

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

marcelolx
Copy link
Contributor

@marcelolx marcelolx commented May 25, 2021

We're already running our app with ruby 3 without issues related to apartment.

Rails 5.2 doesn't support Ruby 3, that is why I excluded the combination from the matrix.

@marcelolx marcelolx force-pushed the ruby-3 branch 2 times, most recently from c899702 to 5afdd42 Compare May 25, 2021 23:39
@marcelolx marcelolx marked this pull request as ready for review May 25, 2021 23:56
Copy link
Contributor

@rpbaltazar rpbaltazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rpbaltazar rpbaltazar merged commit 0ed15c8 into rails-on-services:development Jun 25, 2021
@marcelolx marcelolx deleted the ruby-3 branch June 25, 2021 12:05
rpbaltazar added a commit that referenced this pull request Sep 13, 2021
**Implemented enhancements:**

- #112 - Allow a list of schemas when switching using schemas - #154
- Create schema between different versions of DB - #155 

**Fixed bugs:**

- #170 - Cache Key breaks on rails 6.0.4 - #171 

**Closed issues:**

- Add ruby 3 to the build matrix - #162 
- update rubocop and fixed broken rules - #157 
- added junit formatter and saving test output in circle - #172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants