Add rails 7 support #178
Merged
Add rails 7 support #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code didn't have to change to support it, it was just about making the gem requirements a bit more relaxed. To validate everything works as expected, rails 7 is added to the test matrix. Closes rails-on-services#177
Comment on lines
-6
to
-11
| gem "rubocop" | ||
|
|
||
| group :local do | ||
| gem "guard-rspec", "~> 4.2" | ||
| gem "pry" | ||
| end |
There was a problem hiding this comment.
I am not sure why these gems where here in the first place. They are not present in the Appraisals file so I wasn't sure if I should re-add them manually.
rpbaltazar
approved these changes
Feb 1, 2022
|
Thank you |
rpbaltazar
added a commit
that referenced
this pull request
Feb 7, 2022
**Implemented enhancements:** - Increase errors visibility by showing more information on the underlying error rather than a generic error 'Apartment::TenantNotFound' (#176) - Resolved #177 - Added rails 7 support (#178) **Fixed bugs:** - Fixing tenant_presence_check config in the README (#180) - Resolved #161 and #81 - Fixed sequence name (#187) **Closed issues:** - Resolved #151 - removed reloader and console overwrite of reload method (#174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code didn't have to change to support it, it was just about
making the gem requirements a bit more relaxed. To validate everything
works as expected, rails 7 is added to the test matrix.
Closes #177